From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 109F3ECE59D for ; Wed, 16 Oct 2019 03:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E089120873 for ; Wed, 16 Oct 2019 03:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390889AbfJPDTw (ORCPT ); Tue, 15 Oct 2019 23:19:52 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43808 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbfJPDTv (ORCPT ); Tue, 15 Oct 2019 23:19:51 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0364E128F3874; Tue, 15 Oct 2019 20:19:50 -0700 (PDT) Date: Tue, 15 Oct 2019 20:19:50 -0700 (PDT) Message-Id: <20191015.201950.641044017625677016.davem@davemloft.net> To: edumazet@google.com Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH net-next] net_sched: sch_fq: remove one obsolete check in fq_dequeue() From: David Miller In-Reply-To: <20191014174032.138670-1-edumazet@google.com> References: <20191014174032.138670-1-edumazet@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 15 Oct 2019 20:19:51 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet Date: Mon, 14 Oct 2019 10:40:32 -0700 > After commit eeb84aa0d0aff ("net_sched: sch_fq: do not assume EDT > packets are ordered"), all skbs get a non zero time_to_send > in flow_queue_add() > > This means @time_next_packet variable in fq_dequeue() > can no longer be zero. > > Signed-off-by: Eric Dumazet Applied.