From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F85BC4360C for ; Wed, 16 Oct 2019 03:33:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10A1620663 for ; Wed, 16 Oct 2019 03:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391050AbfJPDd3 (ORCPT ); Tue, 15 Oct 2019 23:33:29 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43994 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730211AbfJPDd2 (ORCPT ); Tue, 15 Oct 2019 23:33:28 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0DFED12B88C22; Tue, 15 Oct 2019 20:33:28 -0700 (PDT) Date: Tue, 15 Oct 2019 20:33:27 -0700 (PDT) Message-Id: <20191015.203327.2130838944283050049.davem@davemloft.net> To: vinicius.gomes@intel.com Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, ederson.desouza@intel.com Subject: Re: [PATCH net v1] sched: etf: Fix ordering of packets with same txtime From: David Miller In-Reply-To: <20191014203822.31741-1-vinicius.gomes@intel.com> References: <20191014203822.31741-1-vinicius.gomes@intel.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 15 Oct 2019 20:33:28 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vinicius Costa Gomes Date: Mon, 14 Oct 2019 13:38:22 -0700 > When a application sends many packets with the same txtime, they may > be transmitted out of order (different from the order in which they > were enqueued). > > This happens because when inserting elements into the tree, when the > txtime of two packets are the same, the new packet is inserted at the > left side of the tree, causing the reordering. The only effect of this > change should be that packets with the same txtime will be transmitted > in the order they are enqueued. > > The application in question (the AVTP GStreamer plugin, still in > development) is sending video traffic, in which each video frame have > a single presentation time, the problem is that when packetizing, > multiple packets end up with the same txtime. > > The receiving side was rejecting packets because they were being > received out of order. > > Fixes: 25db26a91364 ("net/sched: Introduce the ETF Qdisc") > Reported-by: Ederson de Souza > Signed-off-by: Vinicius Costa Gomes Applied and queued up for -stable, thank you.