* [PATCH] vsock/virtio: remove unused 'work' field from 'struct virtio_vsock_pkt'
@ 2019-10-15 15:00 Stefano Garzarella
2019-10-16 3:55 ` David Miller
2019-10-16 14:50 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Stefano Garzarella @ 2019-10-15 15:00 UTC (permalink / raw)
To: virtualization
Cc: kvm, Stefan Hajnoczi, Michael S. Tsirkin, Jason Wang,
linux-kernel, netdev
The 'work' field was introduced with commit 06a8fc78367d0
("VSOCK: Introduce virtio_vsock_common.ko")
but it is never used in the code, so we can remove it to save
memory allocated in the per-packet 'struct virtio_vsock_pkt'
Suggested-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
include/linux/virtio_vsock.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h
index 4c7781f4b29b..07875ccc7bb5 100644
--- a/include/linux/virtio_vsock.h
+++ b/include/linux/virtio_vsock.h
@@ -48,7 +48,6 @@ struct virtio_vsock_sock {
struct virtio_vsock_pkt {
struct virtio_vsock_hdr hdr;
- struct work_struct work;
struct list_head list;
/* socket refcnt not held, only use for cancellation */
struct vsock_sock *vsk;
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vsock/virtio: remove unused 'work' field from 'struct virtio_vsock_pkt'
2019-10-15 15:00 [PATCH] vsock/virtio: remove unused 'work' field from 'struct virtio_vsock_pkt' Stefano Garzarella
@ 2019-10-16 3:55 ` David Miller
2019-10-16 14:50 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-10-16 3:55 UTC (permalink / raw)
To: sgarzare; +Cc: virtualization, kvm, stefanha, mst, jasowang, linux-kernel,
netdev
From: Stefano Garzarella <sgarzare@redhat.com>
Date: Tue, 15 Oct 2019 17:00:51 +0200
> The 'work' field was introduced with commit 06a8fc78367d0
> ("VSOCK: Introduce virtio_vsock_common.ko")
> but it is never used in the code, so we can remove it to save
> memory allocated in the per-packet 'struct virtio_vsock_pkt'
>
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Michael, will you take this? I assume so...
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vsock/virtio: remove unused 'work' field from 'struct virtio_vsock_pkt'
2019-10-15 15:00 [PATCH] vsock/virtio: remove unused 'work' field from 'struct virtio_vsock_pkt' Stefano Garzarella
2019-10-16 3:55 ` David Miller
@ 2019-10-16 14:50 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2019-10-16 14:50 UTC (permalink / raw)
To: Stefano Garzarella
Cc: virtualization, kvm, Michael S. Tsirkin, Jason Wang, linux-kernel,
netdev
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
On Tue, Oct 15, 2019 at 05:00:51PM +0200, Stefano Garzarella wrote:
> The 'work' field was introduced with commit 06a8fc78367d0
> ("VSOCK: Introduce virtio_vsock_common.ko")
> but it is never used in the code, so we can remove it to save
> memory allocated in the per-packet 'struct virtio_vsock_pkt'
>
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> include/linux/virtio_vsock.h | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-16 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-15 15:00 [PATCH] vsock/virtio: remove unused 'work' field from 'struct virtio_vsock_pkt' Stefano Garzarella
2019-10-16 3:55 ` David Miller
2019-10-16 14:50 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).