From: David Miller <davem@davemloft.net>
To: vvidic@valentin-vidic.from.hr
Cc: hslester96@gmail.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+f1842130bbcfb335bac1@syzkaller.appspotmail.com
Subject: Re: [PATCH] net: usb: sr9800: fix uninitialized local variable
Date: Tue, 15 Oct 2019 21:02:49 -0700 (PDT) [thread overview]
Message-ID: <20191015.210249.78012402045984501.davem@davemloft.net> (raw)
In-Reply-To: <20191015202020.29114-1-vvidic@valentin-vidic.from.hr>
From: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Date: Tue, 15 Oct 2019 22:20:20 +0200
> Make sure res does not contain random value if the call to
> sr_read_cmd fails for some reason.
>
> Reported-by: syzbot+f1842130bbcfb335bac1@syzkaller.appspotmail.com
> Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Applied.
But often in situation like this a failed read can more aptly be indicated by
an all-1's value.
prev parent reply other threads:[~2019-10-16 4:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 20:20 [PATCH] net: usb: sr9800: fix uninitialized local variable Valentin Vidic
2019-10-16 4:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015.210249.78012402045984501.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hslester96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+f1842130bbcfb335bac1@syzkaller.appspotmail.com \
--cc=vvidic@valentin-vidic.from.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).