* [PATCH net-next] net: bcmgenet: Add a shutdown callback
@ 2019-10-15 17:36 Florian Fainelli
2019-10-15 17:45 ` Doug Berger
2019-10-16 3:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-10-15 17:36 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Doug Berger, David S. Miller,
open list:BROADCOM GENET ETHERNET DRIVER, open list
Make sure that we completely quiesce the network device, including its
DMA to avoid having it continue to receive packets while there is no
software alive to service those.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 12cb77ef1081..ecbb1e7353ba 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -3597,6 +3597,11 @@ static int bcmgenet_remove(struct platform_device *pdev)
return 0;
}
+static void bcmgenet_shutdown(struct platform_device *pdev)
+{
+ bcmgenet_remove(pdev);
+}
+
#ifdef CONFIG_PM_SLEEP
static int bcmgenet_resume(struct device *d)
{
@@ -3715,6 +3720,7 @@ static SIMPLE_DEV_PM_OPS(bcmgenet_pm_ops, bcmgenet_suspend, bcmgenet_resume);
static struct platform_driver bcmgenet_driver = {
.probe = bcmgenet_probe,
.remove = bcmgenet_remove,
+ .shutdown = bcmgenet_shutdown,
.driver = {
.name = "bcmgenet",
.of_match_table = bcmgenet_match,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: bcmgenet: Add a shutdown callback
2019-10-15 17:36 [PATCH net-next] net: bcmgenet: Add a shutdown callback Florian Fainelli
@ 2019-10-15 17:45 ` Doug Berger
2019-10-16 3:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Doug Berger @ 2019-10-15 17:45 UTC (permalink / raw)
To: Florian Fainelli, netdev
Cc: David S. Miller, open list:BROADCOM GENET ETHERNET DRIVER,
open list
On 10/15/19 10:36 AM, Florian Fainelli wrote:
> Make sure that we completely quiesce the network device, including its
> DMA to avoid having it continue to receive packets while there is no
> software alive to service those.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 12cb77ef1081..ecbb1e7353ba 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -3597,6 +3597,11 @@ static int bcmgenet_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static void bcmgenet_shutdown(struct platform_device *pdev)
> +{
> + bcmgenet_remove(pdev);
> +}
> +
> #ifdef CONFIG_PM_SLEEP
> static int bcmgenet_resume(struct device *d)
> {
> @@ -3715,6 +3720,7 @@ static SIMPLE_DEV_PM_OPS(bcmgenet_pm_ops, bcmgenet_suspend, bcmgenet_resume);
> static struct platform_driver bcmgenet_driver = {
> .probe = bcmgenet_probe,
> .remove = bcmgenet_remove,
> + .shutdown = bcmgenet_shutdown,
> .driver = {
> .name = "bcmgenet",
> .of_match_table = bcmgenet_match,
>
Acked-by: Doug Berger <opendmb@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: bcmgenet: Add a shutdown callback
2019-10-15 17:36 [PATCH net-next] net: bcmgenet: Add a shutdown callback Florian Fainelli
2019-10-15 17:45 ` Doug Berger
@ 2019-10-16 3:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-10-16 3:59 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, opendmb, bcm-kernel-feedback-list, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 15 Oct 2019 10:36:24 -0700
> Make sure that we completely quiesce the network device, including its
> DMA to avoid having it continue to receive packets while there is no
> software alive to service those.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-16 3:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-15 17:36 [PATCH net-next] net: bcmgenet: Add a shutdown callback Florian Fainelli
2019-10-15 17:45 ` Doug Berger
2019-10-16 3:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).