From: David Miller <davem@davemloft.net>
To: vishal@chelsio.com
Cc: netdev@vger.kernel.org, nirranjan@chelsio.com, shahjada@chelsio.com
Subject: Re: [PATCH net] cxgb4: Fix panic when attaching to ULD fails
Date: Wed, 16 Oct 2019 12:19:50 -0700 (PDT) [thread overview]
Message-ID: <20191016.121950.1487403738523364817.davem@davemloft.net> (raw)
In-Reply-To: <1571039435-22495-1-git-send-email-vishal@chelsio.com>
From: Vishal Kulkarni <vishal@chelsio.com>
Date: Mon, 14 Oct 2019 13:20:35 +0530
> @@ -760,7 +762,9 @@ void cxgb4_register_uld(enum cxgb4_uld type,
> if (ret)
> goto free_irq;
> adap->uld[type] = *p;
> - uld_attach(adap, type);
> + ret = uld_attach(adap, type);
> + if (ret)
> + goto free_irq;
You're not freeing up all of the txq_info ULD stuff that setup_sge_txq_uld
created.
prev parent reply other threads:[~2019-10-16 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 7:50 [PATCH net] cxgb4: Fix panic when attaching to ULD fails Vishal Kulkarni
2019-10-15 5:52 ` Simon Horman
2019-10-16 19:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016.121950.1487403738523364817.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=shahjada@chelsio.com \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).