From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7627FA3728 for ; Wed, 16 Oct 2019 20:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE7F521848 for ; Wed, 16 Oct 2019 20:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437183AbfJPU2G (ORCPT ); Wed, 16 Oct 2019 16:28:06 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54002 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437153AbfJPU2G (ORCPT ); Wed, 16 Oct 2019 16:28:06 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D74DC1434B989; Wed, 16 Oct 2019 13:28:05 -0700 (PDT) Date: Wed, 16 Oct 2019 13:28:05 -0700 (PDT) Message-Id: <20191016.132805.1945227679877403030.davem@davemloft.net> To: ben.dooks@codethink.co.uk Cc: linux-kernel@lists.codethink.co.uk, peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: fix argument to stmmac_pcs_ctrl_ane() From: David Miller In-Reply-To: <20191016082205.26899-1-ben.dooks@codethink.co.uk> References: <20191016082205.26899-1-ben.dooks@codethink.co.uk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Oct 2019 13:28:06 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Ben Dooks (Codethink)" Date: Wed, 16 Oct 2019 09:22:05 +0100 > The stmmac_pcs_ctrl_ane() expects a register address as > argument 1, but for some reason the mac_device_info is > being passed. > > Fix the warning (and possible bug) from sparse: > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces) > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: expected void [noderef] *ioaddr > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: got struct mac_device_info *hw > > Signed-off-by: Ben Dooks I'm still reviewing this but FYI you did not have to send this twice. Always check: https://patchwork.ozlabs.org/project/netdev/list/ to see what state your patch submission is in.