* [PATCH] net: aquantia: add an error handling in aq_nic_set_multicast_list
@ 2019-10-17 2:25 Chen Wandun
2019-10-17 16:17 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Chen Wandun @ 2019-10-17 2:25 UTC (permalink / raw)
To: igor.russkikh, davem, netdev, linux-kernel; +Cc: chenwandun
From: Chenwandun <chenwandun@huawei.com>
Signed-off-by: Chenwandun <chenwandun@huawei.com>
---
drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
index 2a18439..137c1de 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
@@ -664,6 +664,8 @@ int aq_nic_set_multicast_list(struct aq_nic_s *self, struct net_device *ndev)
err = hw_ops->hw_multicast_list_set(self->aq_hw,
self->mc_list.ar,
self->mc_list.count);
+ if (err < 0)
+ return err;
}
return aq_nic_set_packet_filter(self, packet_filter);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: aquantia: add an error handling in aq_nic_set_multicast_list
2019-10-17 2:25 [PATCH] net: aquantia: add an error handling in aq_nic_set_multicast_list Chen Wandun
@ 2019-10-17 16:17 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2019-10-17 16:17 UTC (permalink / raw)
To: Chen Wandun; +Cc: igor.russkikh, davem, netdev, linux-kernel
On Thu, Oct 17, 2019 at 10:25:16AM +0800, Chen Wandun wrote:
> From: Chenwandun <chenwandun@huawei.com>
Hi Chen
There needs to be some sort of commit message. What [problems are you
seeing? That does this fix?
Thanks
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-17 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-17 2:25 [PATCH] net: aquantia: add an error handling in aq_nic_set_multicast_list Chen Wandun
2019-10-17 16:17 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).