From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, jiri@resnulli.us, saeedm@mellanox.com,
vishal@chelsio.com, vladbu@mellanox.com, ecree@solarflare.com
Subject: Re: [PATCH net-next,v5 3/4] net: flow_offload: mangle action at byte level
Date: Thu, 17 Oct 2019 19:46:03 +0200 [thread overview]
Message-ID: <20191017174603.m3riooywbgy2r5hr@salvia> (raw)
In-Reply-To: <20191017103059.3b7ff828@cakuba.netronome.com>
On Thu, Oct 17, 2019 at 10:30:59AM -0700, Jakub Kicinski wrote:
[...]
> Ed requested this was a opt-in/helper the driver can call if they
> choose to. Please do that. Please provide selftests.
I will follow up to support for mangling two ports with one single u32
word, no problem.
Making this opt-in will just leave things as bad as they are right
now, with drivers that are very much hard to read.
next prev parent reply other threads:[~2019-10-17 17:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 22:10 [PATCH net-next,v5 0/4] flow_offload: update mangle action representation Pablo Neira Ayuso
2019-10-14 22:10 ` [PATCH net-next,v5 1/4] net: flow_offload: flip mangle action mask Pablo Neira Ayuso
2019-10-15 6:05 ` Jiri Pirko
2019-10-14 22:10 ` [PATCH net-next,v5 2/4] net: flow_offload: bitwise AND on mangle action value field Pablo Neira Ayuso
2019-10-15 6:12 ` Jiri Pirko
2019-10-14 22:10 ` [PATCH net-next,v5 3/4] net: flow_offload: mangle action at byte level Pablo Neira Ayuso
2019-10-15 8:48 ` kbuild test robot
2019-10-15 8:48 ` [RFC PATCH] net: flow_offload: tc_proto_udp_hdr[] can be static kbuild test robot
2019-10-16 23:36 ` [PATCH net-next,v5 3/4] net: flow_offload: mangle action at byte level Jakub Kicinski
2019-10-17 16:11 ` Pablo Neira Ayuso
2019-10-17 16:22 ` Pablo Neira Ayuso
2019-10-17 17:59 ` Edward Cree
2019-10-17 18:02 ` David Miller
2019-10-17 17:30 ` Jakub Kicinski
2019-10-17 17:46 ` Pablo Neira Ayuso [this message]
2019-10-17 18:01 ` Edward Cree
2019-10-17 18:03 ` David Miller
2019-10-14 22:10 ` [PATCH net-next,v5 4/4] netfilter: nft_payload: packet mangling offload support Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017174603.m3riooywbgy2r5hr@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=vishal@chelsio.com \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox