From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>,
hkallweit1@gmail.com, bcm-kernel-feedback-list@broadcom.com,
olteanv@gmail.com, rmk+kernel@armlinux.org.uk, cphealy@gmail.com,
Jose Abreu <joabreu@synopsys.com>
Subject: Re: [PATCH net-next v2 2/2] net: phy: Add ability to debug RGMII connections
Date: Fri, 18 Oct 2019 00:14:49 +0200 [thread overview]
Message-ID: <20191017221449.GC24810@lunn.ch> (raw)
In-Reply-To: <20191017214453.18934-3-f.fainelli@gmail.com>
> +#ifdef CONFIG_PHY_RGMII_DEBUG
> +int phy_rgmii_debug_probe(struct phy_device *phydev);
> +#else
> +static inline int phy_rgmii_debug_probe(struct phy_device *phydev)
> +{
> + return -EOPNOTSUPP;
> +}
> +#endif
Hi Florian
Jose wanted to make use of this in his self test code for stmmac. I
think to make this more user friendly in that setup, it would be good
to return the phy_mode which works, if only one works. The MAC driver
can then compare the what it thinks the mode should be to what
actually works, and report a test failure if they differ.
Andrew
prev parent reply other threads:[~2019-10-17 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 21:44 [PATCH net-next v2 0/2] net: phy: Add ability to debug RGMII Florian Fainelli
2019-10-17 21:44 ` [PATCH net-next v2 1/2] net: phy: Use genphy_loopback() by default Florian Fainelli
2019-10-17 21:59 ` Andrew Lunn
2019-10-17 21:44 ` [PATCH net-next v2 2/2] net: phy: Add ability to debug RGMII connections Florian Fainelli
2019-10-17 22:11 ` Andrew Lunn
2019-10-17 22:14 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017221449.GC24810@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).