From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
jakub.kicinski@netronome.com, andrew@lunn.ch, mlxsw@mellanox.com
Subject: Re: [patch net-next] devlink: add format requirement for devlink param names
Date: Fri, 18 Oct 2019 09:33:22 -0700 [thread overview]
Message-ID: <20191018093322.0a79b622@hermes.lan> (raw)
In-Reply-To: <20191018160726.18901-1-jiri@resnulli.us>
On Fri, 18 Oct 2019 18:07:26 +0200
Jiri Pirko <jiri@resnulli.us> wrote:
> +static bool devlink_param_valid_name(const char *name)
> +{
> + int len = strlen(name);
> + int i;
> +
> + /* Name can contain lowercase characters or digits.
> + * Underscores are also allowed, but not at the beginning
> + * or end of the name and not more than one in a row.
> + */
> +
> + for (i = 0; i < len; i++) {
Very minor stuff.
1. since strlen technically returns size_t why not make both i and len type size_t
2. no blank line after comment and before loop?
next prev parent reply other threads:[~2019-10-18 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 16:07 [patch net-next] devlink: add format requirement for devlink param names Jiri Pirko
2019-10-18 16:25 ` Jakub Kicinski
2019-10-18 16:58 ` Jiri Pirko
2019-10-18 16:33 ` Stephen Hemminger [this message]
2019-10-18 16:58 ` Jiri Pirko
2019-10-18 16:35 ` Stephen Hemminger
2019-10-18 16:58 ` Jiri Pirko
2019-10-18 17:43 ` Andrew Lunn
2019-10-18 20:08 ` Jiri Pirko
2019-10-18 20:27 ` Andrew Lunn
2019-10-18 21:34 ` Jakub Kicinski
2019-10-19 5:39 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018093322.0a79b622@hermes.lan \
--to=stephen@networkplumber.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).