From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
oss-drivers@netronome.com, xiyou.wangcong@gmail.com
Subject: Re: [PATCH net v2 0/2] net: netem: fix further issues with packet corruption
Date: Fri, 18 Oct 2019 09:36:14 -0700 [thread overview]
Message-ID: <20191018093614.32a023fd@hermes.lan> (raw)
In-Reply-To: <20191018161658.26481-1-jakub.kicinski@netronome.com>
On Fri, 18 Oct 2019 09:16:56 -0700
Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> Hi!
>
> This set is fixing two more issues with the netem packet corruption.
>
> First patch (which was previously posted) avoids NULL pointer dereference
> if the first frame gets freed due to allocation or checksum failure.
> v2 improves the clarity of the code a little as requested by Cong.
>
> Second patch ensures we don't return SUCCESS if the frame was in fact
> dropped. Thanks to this commit message for patch 1 no longer needs the
> "this will still break with a single-frame failure" disclaimer.
>
> Jakub Kicinski (2):
> net: netem: fix error path for corrupted GSO frames
> net: netem: correct the parent's backlog when corrupted packet was
> dropped
>
> net/sched/sch_netem.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
LGTM
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2019-10-18 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 16:16 [PATCH net v2 0/2] net: netem: fix further issues with packet corruption Jakub Kicinski
2019-10-18 16:16 ` [PATCH net v2 1/2] net: netem: fix error path for corrupted GSO frames Jakub Kicinski
2019-10-18 16:16 ` [PATCH net v2 2/2] net: netem: correct the parent's backlog when corrupted packet was dropped Jakub Kicinski
2019-10-18 16:36 ` Stephen Hemminger [this message]
2019-10-19 19:14 ` [PATCH net v2 0/2] net: netem: fix further issues with packet corruption David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018093614.32a023fd@hermes.lan \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).