From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch,
mlxsw@mellanox.com
Subject: Re: [patch net-next] devlink: add format requirement for devlink param names
Date: Fri, 18 Oct 2019 18:58:55 +0200 [thread overview]
Message-ID: <20191018165855.GH2185@nanopsycho> (raw)
In-Reply-To: <20191018092550.6d599f0d@cakuba.netronome.com>
Fri, Oct 18, 2019 at 06:25:50PM CEST, jakub.kicinski@netronome.com wrote:
>On Fri, 18 Oct 2019 18:07:26 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Currently, the name format is not required by the code, however it is
>> required during patch review. All params added until now are in-lined
>> with the following format:
>> 1) lowercase characters, digits and underscored are allowed
>> 2) underscore is neither at the beginning nor at the end and
>> there is no more than one in a row.
>>
>> Add checker to the code to require this format from drivers and warn if
>> they don't follow.
>>
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>
>Looks good, I could nit pick that length of 0 could also be disallowed
>since we're checking validity, but why would I :)
Okay.
>
>Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
next prev parent reply other threads:[~2019-10-18 16:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 16:07 [patch net-next] devlink: add format requirement for devlink param names Jiri Pirko
2019-10-18 16:25 ` Jakub Kicinski
2019-10-18 16:58 ` Jiri Pirko [this message]
2019-10-18 16:33 ` Stephen Hemminger
2019-10-18 16:58 ` Jiri Pirko
2019-10-18 16:35 ` Stephen Hemminger
2019-10-18 16:58 ` Jiri Pirko
2019-10-18 17:43 ` Andrew Lunn
2019-10-18 20:08 ` Jiri Pirko
2019-10-18 20:27 ` Andrew Lunn
2019-10-18 21:34 ` Jakub Kicinski
2019-10-19 5:39 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018165855.GH2185@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).