From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02795CA9EA0 for ; Fri, 18 Oct 2019 17:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0A6E222BD for ; Fri, 18 Oct 2019 17:43:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="swltek4w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634446AbfJRRnH (ORCPT ); Fri, 18 Oct 2019 13:43:07 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53022 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2634394AbfJRRnH (ORCPT ); Fri, 18 Oct 2019 13:43:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=f+m4prAthfS+puv2mnsX7UxovnvVr7AlkdjyJWN6XuU=; b=swltek4wmdnOfZteRdu6q52yeS +cBdh1DBOkX4zAMTVdXwxOUbSWsIS+Bs4COsQJSqdWWuWbBbDLCzRa/QyqMO75MWVpcpMUvGwDGR9 R1CDgHDhAuy0HDfXpeKhIxauiNX1xJB32O/TWUuV/a5THshYzkto5pYEkYLlnIsGemMQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iLWHI-0002S7-1k; Fri, 18 Oct 2019 19:43:04 +0200 Date: Fri, 18 Oct 2019 19:43:04 +0200 From: Andrew Lunn To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, jakub.kicinski@netronome.com, mlxsw@mellanox.com Subject: Re: [patch net-next] devlink: add format requirement for devlink param names Message-ID: <20191018174304.GE24810@lunn.ch> References: <20191018160726.18901-1-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018160726.18901-1-jiri@resnulli.us> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 18, 2019 at 06:07:26PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Currently, the name format is not required by the code, however it is > required during patch review. All params added until now are in-lined > with the following format: > 1) lowercase characters, digits and underscored are allowed > 2) underscore is neither at the beginning nor at the end and > there is no more than one in a row. > > Add checker to the code to require this format from drivers and warn if > they don't follow. Hi Jiri Could you add a reference to where these requirements are derived from. What can go wrong if they are ignored? I assume it is something to do with sysfs? Andrew