* [PATCH v2] net: aquantia: add an error handling in aq_nic_set_multicast_list
@ 2019-10-18 10:20 Chen Wandun
2019-10-18 13:01 ` Igor Russkikh
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chen Wandun @ 2019-10-18 10:20 UTC (permalink / raw)
To: igor.russkikh, davem, netdev, linux-kernel; +Cc: chenwandun
From: Chenwandun <chenwandun@huawei.com>
add an error handling in aq_nic_set_multicast_list, it may not
work when hw_multicast_list_set error; and at the same time
it will remove gcc Wunused-but-set-variable warning.
Signed-off-by: Chenwandun <chenwandun@huawei.com>
---
drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
index 2a18439..137c1de 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
@@ -664,6 +664,8 @@ int aq_nic_set_multicast_list(struct aq_nic_s *self, struct net_device *ndev)
err = hw_ops->hw_multicast_list_set(self->aq_hw,
self->mc_list.ar,
self->mc_list.count);
+ if (err < 0)
+ return err;
}
return aq_nic_set_packet_filter(self, packet_filter);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] net: aquantia: add an error handling in aq_nic_set_multicast_list
2019-10-18 10:20 [PATCH v2] net: aquantia: add an error handling in aq_nic_set_multicast_list Chen Wandun
@ 2019-10-18 13:01 ` Igor Russkikh
2019-10-18 19:04 ` Andrew Lunn
2019-10-19 19:17 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Igor Russkikh @ 2019-10-18 13:01 UTC (permalink / raw)
To: Chen Wandun, davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Thanks, Chen.
On 18.10.2019 13:20, Chen Wandun wrote:
> From: Chenwandun <chenwandun@huawei.com>
>
> add an error handling in aq_nic_set_multicast_list, it may not
> work when hw_multicast_list_set error; and at the same time
> it will remove gcc Wunused-but-set-variable warning.
>
> Signed-off-by: Chenwandun <chenwandun@huawei.com>
Reviewed-by: Igor Russkikh <igor.russkikh@aquantia.com>
Regards,
Igor
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net: aquantia: add an error handling in aq_nic_set_multicast_list
2019-10-18 10:20 [PATCH v2] net: aquantia: add an error handling in aq_nic_set_multicast_list Chen Wandun
2019-10-18 13:01 ` Igor Russkikh
@ 2019-10-18 19:04 ` Andrew Lunn
2019-10-19 19:17 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2019-10-18 19:04 UTC (permalink / raw)
To: Chen Wandun; +Cc: igor.russkikh, davem, netdev, linux-kernel
On Fri, Oct 18, 2019 at 06:20:37PM +0800, Chen Wandun wrote:
> From: Chenwandun <chenwandun@huawei.com>
>
> add an error handling in aq_nic_set_multicast_list, it may not
> work when hw_multicast_list_set error; and at the same time
> it will remove gcc Wunused-but-set-variable warning.
>
> Signed-off-by: Chenwandun <chenwandun@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net: aquantia: add an error handling in aq_nic_set_multicast_list
2019-10-18 10:20 [PATCH v2] net: aquantia: add an error handling in aq_nic_set_multicast_list Chen Wandun
2019-10-18 13:01 ` Igor Russkikh
2019-10-18 19:04 ` Andrew Lunn
@ 2019-10-19 19:17 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-10-19 19:17 UTC (permalink / raw)
To: chenwandun; +Cc: igor.russkikh, netdev, linux-kernel
From: Chen Wandun <chenwandun@huawei.com>
Date: Fri, 18 Oct 2019 18:20:37 +0800
> From: Chenwandun <chenwandun@huawei.com>
>
> add an error handling in aq_nic_set_multicast_list, it may not
> work when hw_multicast_list_set error; and at the same time
> it will remove gcc Wunused-but-set-variable warning.
>
> Signed-off-by: Chenwandun <chenwandun@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-19 19:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-18 10:20 [PATCH v2] net: aquantia: add an error handling in aq_nic_set_multicast_list Chen Wandun
2019-10-18 13:01 ` Igor Russkikh
2019-10-18 19:04 ` Andrew Lunn
2019-10-19 19:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).