Re: [patch net-next] devlink: add format requirement for devlink param names

[Jiri Pirko <jiri@resnulli.us>]

Fri, Oct 18, 2019 at 07:43:04PM CEST, andrew@lunn.ch wrote:
>On Fri, Oct 18, 2019 at 06:07:26PM +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>> 
>> Currently, the name format is not required by the code, however it is
>> required during patch review. All params added until now are in-lined
>> with the following format:
>> 1) lowercase characters, digits and underscored are allowed
>> 2) underscore is neither at the beginning nor at the end and
>>    there is no more than one in a row.
>> 
>> Add checker to the code to require this format from drivers and warn if
>> they don't follow.
>
>Hi Jiri
>
>Could you add a reference to where these requirements are derived
>from. What can go wrong if they are ignored? I assume it is something

Well, no reference. All existing params, both generic and driver
specific are following this format. I just wanted to make that required
so all params are looking similar.


>to do with sysfs?

No, why would you think so?


>
>      Andrew