public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jakub.kicinski@netronome.com,
	andrew@lunn.ch, mlxsw@mellanox.com
Subject: Re: [patch net-next v2] devlink: add format requirement for devlink param names
Date: Mon, 21 Oct 2019 09:58:30 +0200	[thread overview]
Message-ID: <20191021075830.GR2185@nanopsycho> (raw)
In-Reply-To: <20191018170951.26822-1-jiri@resnulli.us>

Fri, Oct 18, 2019 at 07:09:51PM CEST, jiri@resnulli.us wrote:
>From: Jiri Pirko <jiri@mellanox.com>
>
>Currently, the name format is not required by the code, however it is
>required during patch review. All params added until now are in-lined
>with the following format:
>1) lowercase characters, digits and underscored are allowed
>2) underscore is neither at the beginning nor at the end and
>   there is no more than one in a row.
>
>Add checker to the code to require this format from drivers and warn if
>they don't follow.
>
>Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>---
>v1->v2:
>- removed empty line after comment
>- added check for empty string
>- converted i and len to size_t and put on a single line
>- s/valid_name/name_valid/ to be aligned with the rest

Will send v3 which would allow uppercase and will make it part of
patchset that would check more devlink strings.

      parent reply	other threads:[~2019-10-21  7:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 17:09 [patch net-next v2] devlink: add format requirement for devlink param names Jiri Pirko
2019-10-18 18:39 ` Jakub Kicinski
2019-10-21  7:58 ` Jiri Pirko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191021075830.GR2185@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox