From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 05/16] net: dsa: use ports list to setup switches
Date: Mon, 21 Oct 2019 14:49:02 +0200 [thread overview]
Message-ID: <20191021124902.GF16084@lunn.ch> (raw)
In-Reply-To: <21738767-7e98-6c4c-ba1c-bea29142d481@gmail.com>
On Sun, Oct 20, 2019 at 07:42:15PM -0700, Florian Fainelli wrote:
>
>
> On 10/19/2019 8:19 PM, Vivien Didelot wrote:
> > Use the new ports list instead of iterating over switches and their
> > ports when setting up the switches and their ports.
> >
> > At the same time, provide setup states and messages for ports and
> > switches as it is done for the trees.
>
> Humm, that becomes quite noisy, would it make sense to have those
> messages only for non-user ports that are not already visible because
> they do not have a net_device?
I agree, it looks noise. Maybe change them to _dbg()?
> If you have multiple switches in a fabric, it might be convenient to use
> dev_info(dp->ds->dev, ...) to print your message so you can clearly
> identify which port belongs to which switch, which becomes even more
> important as it is all flattened thanks to lists now. What do you think?
I do think it needs to identify both the dst and the ds.
Andrew
next prev parent reply other threads:[~2019-10-21 12:49 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 3:19 [PATCH net-next 00/16] net: dsa: turn arrays of ports into a list Vivien Didelot
2019-10-20 3:19 ` [PATCH net-next 01/16] net: dsa: use dsa_to_port helper everywhere Vivien Didelot
2019-10-21 2:34 ` Florian Fainelli
2019-10-21 12:31 ` Andrew Lunn
2019-10-21 15:44 ` Vivien Didelot
2019-10-20 3:19 ` [PATCH net-next 02/16] net: dsa: add ports list in the switch fabric Vivien Didelot
2019-10-21 2:36 ` Florian Fainelli
2019-10-21 2:58 ` Florian Fainelli
2019-10-21 12:37 ` Andrew Lunn
2019-10-21 20:00 ` Vivien Didelot
2019-10-20 3:19 ` [PATCH net-next 03/16] net: dsa: use ports list in dsa_to_port Vivien Didelot
2019-10-21 2:38 ` Florian Fainelli
2019-10-21 12:39 ` Andrew Lunn
2019-10-20 3:19 ` [PATCH net-next 04/16] net: dsa: use ports list to find slave Vivien Didelot
2019-10-21 2:39 ` Florian Fainelli
2019-10-21 12:42 ` Andrew Lunn
2019-10-20 3:19 ` [PATCH net-next 05/16] net: dsa: use ports list to setup switches Vivien Didelot
2019-10-21 2:42 ` Florian Fainelli
2019-10-21 12:49 ` Andrew Lunn [this message]
2019-10-21 19:37 ` Vivien Didelot
2019-10-20 3:19 ` [PATCH net-next 06/16] net: dsa: use ports list for routing table setup Vivien Didelot
2019-10-21 2:42 ` Florian Fainelli
2019-10-21 12:50 ` Andrew Lunn
2019-10-20 3:19 ` [PATCH net-next 07/16] net: dsa: use ports list to find a port by node Vivien Didelot
2019-10-21 2:43 ` Florian Fainelli
2019-10-20 3:19 ` [PATCH net-next 08/16] net: dsa: use ports list to setup multiple master devices Vivien Didelot
2019-10-21 3:03 ` Florian Fainelli
2019-10-21 14:17 ` Andrew Lunn
2019-10-20 3:19 ` [PATCH net-next 09/16] net: dsa: use ports list to find first CPU port Vivien Didelot
2019-10-21 2:46 ` Florian Fainelli
2019-10-20 3:19 ` [PATCH net-next 10/16] net: dsa: use ports list to setup default " Vivien Didelot
2019-10-21 2:47 ` Florian Fainelli
2019-10-20 3:19 ` [PATCH net-next 11/16] net: dsa: mv88e6xxx: silently skip PVT ops Vivien Didelot
2019-10-21 2:48 ` Florian Fainelli
2019-10-20 3:19 ` [PATCH net-next 12/16] net: dsa: mv88e6xxx: use ports list to map port VLAN Vivien Didelot
2019-10-21 2:50 ` Florian Fainelli
2019-10-20 3:19 ` [PATCH net-next 13/16] net: dsa: mv88e6xxx: use ports list to map bridge Vivien Didelot
2019-10-21 2:52 ` Florian Fainelli
2019-10-20 3:19 ` [PATCH net-next 14/16] net: dsa: sja1105: register switch before assigning port private data Vivien Didelot
2019-10-20 3:19 ` [PATCH net-next 15/16] net: dsa: allocate ports on touch Vivien Didelot
2019-10-21 2:56 ` Florian Fainelli
2019-10-20 3:19 ` [PATCH net-next 16/16] net: dsa: remove dsa_switch_alloc helper Vivien Didelot
2019-10-21 2:55 ` Florian Fainelli
2019-10-21 18:32 ` [PATCH net-next 00/16] net: dsa: turn arrays of ports into a list David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021124902.GF16084@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).