From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B58C9CA9EB7 for ; Mon, 21 Oct 2019 14:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C89820882 for ; Mon, 21 Oct 2019 14:17:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="tWPGkhZC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbfJUORb (ORCPT ); Mon, 21 Oct 2019 10:17:31 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55596 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727680AbfJUORa (ORCPT ); Mon, 21 Oct 2019 10:17:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Jgv/JiY9a5I5w4sH96aTClgjxrSZfSDUHF7+EXcVTKM=; b=tWPGkhZCTIq3v4COdlYxrCK7Ge 1tq8PRpOElMfJhEVDHPKZqXZVAi7JnM1xrLdA8kl4H15uYXJzaSD+UqTFCq+oD/skmFU+E0oglD+z Io2xZ2KWlf8aYSA5kh4MBbavhtOj/6zh7B6IBuBr7pFSlS0748XEjH6AnbEvtvWZnnGk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iMYUx-0004pX-Fx; Mon, 21 Oct 2019 16:17:27 +0200 Date: Mon, 21 Oct 2019 16:17:27 +0200 From: Andrew Lunn To: Florian Fainelli Cc: Vivien Didelot , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 08/16] net: dsa: use ports list to setup multiple master devices Message-ID: <20191021141727.GD17002@lunn.ch> References: <20191020031941.3805884-1-vivien.didelot@gmail.com> <20191020031941.3805884-9-vivien.didelot@gmail.com> <55f1256b-c1b3-f222-9275-c0cc969a59ab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55f1256b-c1b3-f222-9275-c0cc969a59ab@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Oct 20, 2019 at 08:03:34PM -0700, Florian Fainelli wrote: > > > On 10/19/2019 8:19 PM, Vivien Didelot wrote: > > Now that we have a potential list of CPU ports, make use of it instead > > of only configuring the master device of an unique CPU port. > > Out of your series, this is the only one that has possible side effects > to existing set-up in that if you had multiple CPU ports defined, today, > we would stop at the first one, whereas now, we will set them all up. I > believe this is right way to do it, but have not had time to fire up a > test on a BCM7278 w/ bcm_sf2 and this patch series to confirm that, will > do that first thing tomorrow morning. Hi Florian The next patch might also change things, finding the first CPU port. Is the order of the link list the same as searching the port array? Andrew