From: Andrew Lunn <andrew@lunn.ch>
To: David Ahern <dsahern@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, davem@davemloft.net,
jakub.kicinski@netronome.com, mlxsw@mellanox.com
Subject: Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names
Date: Mon, 21 Oct 2019 17:28:20 +0200 [thread overview]
Message-ID: <20191021152820.GE17002@lunn.ch> (raw)
In-Reply-To: <60dc428e-679e-fb16-38c2-82900c9013de@gmail.com>
On Mon, Oct 21, 2019 at 09:20:07AM -0600, David Ahern wrote:
> On 10/21/19 8:26 AM, Jiri Pirko wrote:
> > From: Jiri Pirko <jiri@mellanox.com>
> >
> > Currently, the name format is not required by the code, however it is
> > required during patch review. All params added until now are in-lined
> > with the following format:
> > 1) lowercase characters, digits and underscored are allowed
> > 2) underscore is neither at the beginning nor at the end and
> > there is no more than one in a row.
> >
> > Add checker to the code to require this format from drivers and warn if
> > they don't follow. This applies to params, resources, reporters,
> > traps, trap groups, dpipe tables and dpipe fields.
> >
>
> This seems random and without any real cause. There is no reason to
> exclude dash and uppercase for example in the names.
Hi David
The commit message is out of date. Upper case is now allowed.
Andrew
next prev parent reply other threads:[~2019-10-21 15:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 14:26 [patch net-next v3 0/3] devlink: add format requirement for devlink object names Jiri Pirko
2019-10-21 14:26 ` [patch net-next v3 1/3] netdevsim: change name of fib rules resource Jiri Pirko
2019-10-21 14:26 ` [patch net-next v3 2/3] devlink: replace spaces in dpipe field names Jiri Pirko
2019-10-21 15:17 ` David Ahern
2019-10-21 14:26 ` [patch net-next v3 3/3] devlink: add format requirement for devlink object names Jiri Pirko
2019-10-21 15:20 ` David Ahern
2019-10-21 15:28 ` Andrew Lunn [this message]
2019-10-21 15:56 ` Jiri Pirko
2019-10-21 16:11 ` David Ahern
2019-10-22 5:59 ` Jiri Pirko
2019-10-23 22:16 ` David Ahern
2019-10-24 6:06 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021152820.GE17002@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).