From: Andrew Lunn <andrew@lunn.ch>
To: "Thomas Hämmerle" <Thomas.Haemmerle@wolfvision.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"m.tretter@pengutronix.de" <m.tretter@pengutronix.de>
Subject: Re: [PATCH] net: phy: dp83867: support Wake on LAN
Date: Tue, 22 Oct 2019 14:34:24 +0200 [thread overview]
Message-ID: <20191022123424.GA5707@lunn.ch> (raw)
In-Reply-To: <1571742645-13800-1-git-send-email-thomas.haemmerle@wolfvision.net>
On Tue, Oct 22, 2019 at 11:11:07AM +0000, Thomas Hämmerle wrote:
> + if (wol->wolopts & WAKE_MAGICSECURE) {
> + phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP1,
> + (wol->sopass[1] << 8) | wol->sopass[0]);
> + phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP1,
> + (wol->sopass[3] << 8) | wol->sopass[2]);
> + phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP1,
> + (wol->sopass[5] << 8) | wol->sopass[3]);
Hi Thomas
I see sopass[3] twice here. Is that a typo?
Andrew
next prev parent reply other threads:[~2019-10-22 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 11:11 [PATCH] net: phy: dp83867: support Wake on LAN Thomas Hämmerle
2019-10-22 12:34 ` Andrew Lunn [this message]
2019-10-22 13:06 ` [PATCH v2] " Thomas Hämmerle
2019-10-22 13:30 ` Michael Tretter
2019-10-22 14:00 ` Andrew Lunn
2019-10-22 18:40 ` Heiner Kallweit
2019-10-22 19:15 ` Andrew Lunn
2019-10-24 22:16 ` David Miller
2019-10-25 7:55 ` Thomas Hämmerle
2019-10-28 8:08 ` [PATCH v3] " Thomas Hämmerle
2019-10-29 23:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022123424.GA5707@lunn.ch \
--to=andrew@lunn.ch \
--cc=Thomas.Haemmerle@wolfvision.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=m.tretter@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).