From: Stefano Brivio <sbrivio@redhat.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: David Miller <davem@davemloft.net>,
Hillf Danton <hdanton@sina.com>, Taehee Yoo <ap420073@gmail.com>,
Greg Rose <gvrose8192@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Ying Xue <ying.xue@windriver.com>,
Andrey Konovalov <andreyknvl@google.com>,
Pravin B Shelar <pshelar@ovn.org>,
syzkaller-bugs@googlegroups.com,
syzbot <syzbot+13210896153522fe1ee5@syzkaller.appspotmail.com>,
Jiri Benc <jbenc@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
netdev@vger.kernel.org, dev@openvswitch.org
Subject: Re: [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds
Date: Wed, 23 Oct 2019 02:20:53 +0200 [thread overview]
Message-ID: <20191023022053.0669e33f@elisabeth> (raw)
In-Reply-To: <20191022145316.63bf3b5a@cakuba.netronome.com>
Hi Jakub,
On Tue, 22 Oct 2019 14:53:16 -0700
Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> On Mon, 21 Oct 2019 12:01:57 +0200, Stefano Brivio wrote:
> > From: Hillf Danton <hdanton@sina.com>
> >
> > syzbot found the following crash on:
>
> > The function in net core, register_netdevice(), may fail with vport's
> > destruction callback either invoked or not. After commit 309b66970ee2,
>
> I've added the correct commit quote here, please heed checkpatch'es
> warnings.
I disregarded this warning as it looks redundant to me, given that the
full commit quote is already given in the Fixes: tag below.
In this specific case, I guess it doesn't really make a difference, but
sometimes one needs to mention the same commit multiple times in the
actual message, and while checkpatch would complain about every single
instance, I think that providing the full quote for each of them isn't
very useful and hinders readability.
> > Reported-by: syzbot+13210896153522fe1ee5@syzkaller.appspotmail.com
> > Fixes: 309b66970ee2 ("net: openvswitch: do not free vport if register_netdevice() is failed.")
> > Cc: Taehee Yoo <ap420073@gmail.com>
> > Cc: Greg Rose <gvrose8192@gmail.com>
> > Cc: Eric Dumazet <eric.dumazet@gmail.com>
> > Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> > Cc: Ying Xue <ying.xue@windriver.com>
> > Cc: Andrey Konovalov <andreyknvl@google.com>
> > Signed-off-by: Hillf Danton <hdanton@sina.com>
> > Acked-by: Pravin B Shelar <pshelar@ovn.org>
> > [sbrivio: this was sent to dev@openvswitch.org and never made its way
> > to netdev -- resending original patch]
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> > ---
> > This patch was sent to dev@openvswitch.org and appeared on netdev
> > only as Pravin replied to it, giving his Acked-by. I contacted the
> > original author one month ago requesting to resend this to netdev,
> > but didn't get an answer, so I'm now resending the original patch.
>
> Applied and queued for 4.14+, thanks!
Thank you!
--
Stefano
next prev parent reply other threads:[~2019-10-23 0:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 10:01 [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds Stefano Brivio
2019-10-21 20:21 ` Gregory Rose
2019-10-22 21:53 ` Jakub Kicinski
2019-10-23 0:20 ` Stefano Brivio [this message]
[not found] <20191021110801.16764-1-hdanton@sina.com>
2019-10-21 11:41 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023022053.0669e33f@elisabeth \
--to=sbrivio@redhat.com \
--cc=andreyknvl@google.com \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=gvrose8192@gmail.com \
--cc=hdanton@sina.com \
--cc=jakub.kicinski@netronome.com \
--cc=jbenc@redhat.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=syzbot+13210896153522fe1ee5@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).