From: Andrew Lunn <andrew@lunn.ch>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: phy: dp83867: enable robust auto-mdix
Date: Wed, 23 Oct 2019 17:38:45 +0200 [thread overview]
Message-ID: <20191023153845.GB13748@lunn.ch> (raw)
In-Reply-To: <20191023144846.1381-2-grygorii.strashko@ti.com>
On Wed, Oct 23, 2019 at 05:48:45PM +0300, Grygorii Strashko wrote:
> The link detection timeouts can be observed (or link might not be detected
> at all) when dp83867 PHY is configured in manual mode (speed/duplexity).
>
> CFG3[9] Robust Auto-MDIX option allows significantly improve link detection
> in case dp83867 is configured in manual mode and reduce link detection
> time.
> As per DM: "If link partners are configured to operational modes that are
> not supported by normal Auto MDI/MDIX mode (like Auto-Neg versus Force
> 100Base-TX or Force 100Base-TX versus Force 100Base-TX), this Robust Auto
> MDI/MDIX mode allows MDI/MDIX resolution and prevents deadlock."
>
> Hence, enable this option by default as there are no known reasons
> not to do so.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-10-23 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 14:48 [PATCH 0/2] net: phy: dp83867: enable robust auto-mdix Grygorii Strashko
2019-10-23 14:48 ` [PATCH 1/2] " Grygorii Strashko
2019-10-23 15:38 ` Andrew Lunn [this message]
2019-10-24 2:38 ` Florian Fainelli
2019-10-23 14:48 ` [PATCH 2/2] net: phy: dp83867: move dt parsing to probe Grygorii Strashko
2019-10-23 15:37 ` Andrew Lunn
2019-10-24 2:39 ` Florian Fainelli
2019-10-26 2:25 ` [PATCH 0/2] net: phy: dp83867: enable robust auto-mdix David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023153845.GB13748@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).