From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDD4CA9EBC for ; Thu, 24 Oct 2019 16:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 970F720659 for ; Thu, 24 Oct 2019 16:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lzPfneCj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409907AbfJXQrU (ORCPT ); Thu, 24 Oct 2019 12:47:20 -0400 Received: from mail-qt1-f180.google.com ([209.85.160.180]:33246 "EHLO mail-qt1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405516AbfJXQrU (ORCPT ); Thu, 24 Oct 2019 12:47:20 -0400 Received: by mail-qt1-f180.google.com with SMTP id r5so38882990qtd.0; Thu, 24 Oct 2019 09:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=359J8YcwWQeShpxfO8aTvwah7AWM03igtl5dwiYjcyk=; b=lzPfneCjKpvgn4WeodHOJmtYeQRF4MBzULU9yNEo+U8qML1FQ2MPOjzZlZitXz+kKR 9jHwdOXN5hezHYHeAOJAAlX9tlmTk2w1jyVjB7+Jvx/ihCU8RiYoeeNCETckWDlET2y7 Vv7toew5L8J9BCKkWEspZsZEmytS6DalGXLW9pgi1sz2RR172Y9AJMALvWP48DEpSjwp beDylJ9w4F+vqYVRu4CuiY5zulIZaybrvM4CEekF9ZHChWKuyyZXG6s7UsdmhhuBrWak gd3MC0MAdrQ19idhvoJjbqT1wvJwKyIovARFkb6VtnJ1IrQlYnxKml9/kqSgQ1dmIfFN xRXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=359J8YcwWQeShpxfO8aTvwah7AWM03igtl5dwiYjcyk=; b=KKkP63Vyg03sApTjPnj/jb3XPvzk03fTXnvvfTUa40GzOEeFgAN5Gi+e7h60LPYTLp /wG1EABqNzncUld4EiRo40Zduqi7tsO+tglrL32OUYe3Wk4pUH16xlENCpun06wDiWc7 8t7QVIV0E+xOMyeAI5Dwn115pazqYOTX8n0u6qc+iCTjzpl/rkNlL5Fcly6pJ4VKSndm anMDrh4CboI42IMlUOv6xCeC0Fgk9Kshr6s/KiqYWZzOF5N8QTPznDyKtemTmSf9OyIN bkxHGTd1C6TOhQbEV3S6gf7nGa2WGoc4Bgz3eK0jSWvSY/rgqDLZ7l4CxaMRdZMM07Fo I7bw== X-Gm-Message-State: APjAAAWwTWp98L6O7GjV3NohHEWpUqVIUOPf706vv6GS8004rS6n/G86 d7HZft0qhr3aAKLQz8L/988= X-Google-Smtp-Source: APXvYqyGJ1hmw6uReyM04ZrDuiA3HGt8Ad5AiBRp77uP+V1uiGSWdM9pcx/zTqK9LjZZn/+SydvSrw== X-Received: by 2002:ac8:290f:: with SMTP id y15mr5300194qty.181.1571935638557; Thu, 24 Oct 2019 09:47:18 -0700 (PDT) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id c18sm12080095qkk.17.2019.10.24.09.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 09:47:17 -0700 (PDT) Date: Thu, 24 Oct 2019 12:47:16 -0400 Message-ID: <20191024124716.GB1210163@t480s.localdomain> From: Vivien Didelot To: Colin King Cc: Andrew Lunn , Florian Fainelli , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net: dsa: fix dereference on ds->dev before null check error In-Reply-To: <20191024103218.2592-1-colin.king@canonical.com> References: <20191024103218.2592-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 24 Oct 2019 11:32:18 +0100, Colin King wrote: > From: Colin Ian King > > Currently ds->dev is dereferenced on the assignments of pdata and > np before ds->dev is null checked, hence there is a potential null > pointer dereference on ds->dev. Fix this by assigning pdata and > np after the ds->dev null pointer sanity check. > > Addresses-Coverity: ("Dereference before null check") > Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper") > Signed-off-by: Colin Ian King Reviewed-by: Vivien Didelot