From: Simon Horman <simon.horman@netronome.com>
To: Pankaj Sharma <pankj.sharma@samsung.com>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, wg@grandegger.com,
mkl@pengutronix.de, davem@davemloft.net,
eugen.hristev@microchip.com, ludovic.desroches@microchip.com,
pankaj.dubey@samsung.com, rcsekar@samsung.com,
jhofstee@victronenergy.com, Sriram Dash <sriram.dash@samsung.com>
Subject: Re: [PATCH v2] can: m_can: add support for handling arbitration error
Date: Fri, 25 Oct 2019 13:16:27 +0200 [thread overview]
Message-ID: <20191025111626.GA31153@netronome.com> (raw)
In-Reply-To: <1571660016-29726-1-git-send-email-pankj.sharma@samsung.com>
On Mon, Oct 21, 2019 at 05:43:36PM +0530, Pankaj Sharma wrote:
> The Bosch MCAN hardware (3.1.0 and above) supports interrupt flag to
> detect Protocol error in arbitration phase.
>
> Transmit error statistics is currently not updated from the MCAN driver.
> Protocol error in arbitration phase is a TX error and the network
> statistics should be updated accordingly.
>
> The member "tx_error" of "struct net_device_stats" should be incremented
> as arbitration is a transmit protocol error. Also "arbitration_lost" of
> "struct can_device_stats" should be incremented to report arbitration
> lost.
>
> Signed-off-by: Pankaj Sharma <pankj.sharma@samsung.com>
> Signed-off-by: Sriram Dash <sriram.dash@samsung.com>
> ---
>
> changes in v2:
> - common m_can_ prefix for is_protocol_err function
> - handling stats even if the allocation of the skb fails
> - resolving build errors on net-next branch
No objections from my side.
next prev parent reply other threads:[~2019-10-25 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191021121350epcas5p3313e54a3bc5c8600c52a6db299893f78@epcas5p3.samsung.com>
2019-10-21 12:13 ` [PATCH v2] can: m_can: add support for handling arbitration error Pankaj Sharma
2019-10-25 9:44 ` pankj.sharma
2019-10-25 11:16 ` Simon Horman [this message]
2019-10-29 14:23 ` Marc Kleine-Budde
2019-10-30 5:55 ` pankj.sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025111626.GA31153@netronome.com \
--to=simon.horman@netronome.com \
--cc=davem@davemloft.net \
--cc=eugen.hristev@microchip.com \
--cc=jhofstee@victronenergy.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=pankj.sharma@samsung.com \
--cc=rcsekar@samsung.com \
--cc=sriram.dash@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).