From: Dan Carpenter <dan.carpenter@oracle.com>
To: Samuil Ivanov <samuil.ivanovbg@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
netdev@vger.kernel.org, GR-Linux-NIC-Dev@marvell.com,
linux-kernel@vger.kernel.org, manishc@marvell.com
Subject: Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge
Date: Fri, 25 Oct 2019 17:55:54 +0300 [thread overview]
Message-ID: <20191025145554.GB7244@kadam> (raw)
In-Reply-To: <20191025142842.GA10016@sivanov-pc>
On Fri, Oct 25, 2019 at 05:28:42PM +0300, Samuil Ivanov wrote:
> Dan you are correct it is a bit of a hodge podge :)
> I think that it is better to have a bigger patches that will rename
> more functions, but I don't this it is good to have all the
> functions renamed in one patch.
>
> Just in the header file I counted around 55 function definitions,
> and in the source files there are some more.
> So that will make one huge patch.
>
I don't really have a problem if you rename everything at once. Or if
you want to rename all of them in a 55 patch patchset that's also fine
with me...
regards,
dan carpenter
next prev parent reply other threads:[~2019-10-25 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 21:29 [PATCH 0/3] Staging: qlge: Rename of function prefix ql_ to qlge_ Samuil Ivanov
2019-10-24 21:29 ` [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge Samuil Ivanov
2019-10-25 10:19 ` Dan Carpenter
2019-10-25 14:28 ` Samuil Ivanov
2019-10-25 14:55 ` Dan Carpenter [this message]
2019-10-24 21:29 ` [PATCH 2/3] " Samuil Ivanov
2019-10-24 21:29 ` [PATCH 3/3] " Samuil Ivanov
2019-10-25 3:17 ` [PATCH 0/3] Staging: qlge: Rename of function prefix ql_ to qlge_ Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025145554.GB7244@kadam \
--to=dan.carpenter@oracle.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=samuil.ivanovbg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).