From: Jiri Pirko <jiri@resnulli.us>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
jakub.kicinski@netronome.com, stephen@networkplumber.org,
roopa@cumulusnetworks.com, dcbw@redhat.com,
nikolay@cumulusnetworks.com, mkubecek@suse.cz, andrew@lunn.ch,
parav@mellanox.com, saeedm@mellanox.com, f.fainelli@gmail.com,
sd@queasysnail.net, sbrivio@redhat.com, pabeni@redhat.com,
mlxsw@mellanox.com
Subject: Re: [patch iproute2-next v5 0/3] ip: add support for alternative names
Date: Mon, 28 Oct 2019 08:38:00 +0100 [thread overview]
Message-ID: <20191028073800.GC2193@nanopsycho> (raw)
In-Reply-To: <c8201b72-90c4-d8e6-65b9-b7f7ed55f0f5@gmail.com>
Sun, Oct 27, 2019 at 06:16:25PM CET, dsahern@gmail.com wrote:
>On 10/24/19 4:20 AM, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> This patchset adds support for alternative names caching,
>> manipulation and usage.
>>
>
>something is still not right with this change:
>
>$ ip li add veth1 type veth peer name veth2
>$ ip li prop add dev veth1 altname veth1_by_another_name
>
>$ ip li sh dev veth1
>15: veth1@veth2: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state
>DOWN mode DEFAULT group default qlen 1000
> link/ether 1e:6e:bc:26:52:f6 brd ff:ff:ff:ff:ff:ff
> altname veth1_by_another_name
>
>$ ip li sh dev veth1_by_another_name
>Device "veth1_by_another_name" does not exist.
>
>$ ip li set dev veth1_by_another_name up
>Error: argument "veth1_by_another_name" is wrong: "dev" not a valid ifname
Odd. This works for me fine:
bash-5.0# ip li prop add dev veth1 altname veth1_by_another_name
bash-5.0# ip li sh dev veth1
4: veth1: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/ether 82:ce:19:28:bb:f5 brd ff:ff:ff:ff:ff:ff
altname veth1_by_another_name
bash-5.0# ip li sh dev veth1_by_another_name
4: veth1: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/ether 82:ce:19:28:bb:f5 brd ff:ff:ff:ff:ff:ff
altname veth1_by_another_name
bash-5.0# ip li set dev veth1_by_another_name up
Did you by any chance forget to apply the last patch?
next prev parent reply other threads:[~2019-10-28 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 10:20 [patch iproute2-next v5 0/3] ip: add support for alternative names Jiri Pirko
2019-10-24 10:20 ` [patch iproute2-next v5 1/3] lib/ll_map: cache " Jiri Pirko
2019-10-24 10:20 ` [patch iproute2-next v5 2/3] ip: add support for alternative name addition/deletion/list Jiri Pirko
2019-10-24 10:20 ` [patch iproute2-next v5 3/3] ip: allow to use alternative names as handle Jiri Pirko
2019-10-27 17:16 ` [patch iproute2-next v5 0/3] ip: add support for alternative names David Ahern
2019-10-28 7:38 ` Jiri Pirko [this message]
2019-10-28 14:49 ` David Ahern
2019-10-28 18:19 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028073800.GC2193@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=dsahern@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=mkubecek@suse.cz \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pabeni@redhat.com \
--cc=parav@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=saeedm@mellanox.com \
--cc=sbrivio@redhat.com \
--cc=sd@queasysnail.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox