From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Zhu Yanjun <yanjun.zhu@oracle.com>
Cc: rain.1986.08.12@gmail.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCHv3 1/1] net: forcedeth: add xmit_more support
Date: Tue, 29 Oct 2019 10:32:44 -0700 [thread overview]
Message-ID: <20191029103244.3139a6aa@cakuba.hsd1.ca.comcast.net> (raw)
In-Reply-To: <1572319812-27196-1-git-send-email-yanjun.zhu@oracle.com>
On Mon, 28 Oct 2019 23:30:12 -0400, Zhu Yanjun wrote:
> This change adds support for xmit_more based on the igb commit 6f19e12f6230
> ("igb: flush when in xmit_more mode and under descriptor pressure") and
> commit 6b16f9ee89b8 ("net: move skb->xmit_more hint to softnet data") that
> were made to igb to support this feature. The function netif_xmit_stopped
> is called to check whether transmit queue on device is currently unable to
> send to determine whether we must write the tail because we can add no further
> buffers.
> When normal packets and/or xmit_more packets fill up tx_desc, it is
> necessary to trigger NIC tx reg.
>
> CC: Joe Jin <joe.jin@oracle.com>
> CC: JUNXIAO_BI <junxiao.bi@oracle.com>
> Reported-and-tested-by: Nan san <nan.1986san@gmail.com>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
> Acked-by: Rain River <rain.1986.08.12@gmail.com>
I explained to you nicely that you have to kick on the DMA error cases.
Please stop wasting everyone's time by reposting this.
next prev parent reply other threads:[~2019-10-29 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 3:30 [PATCHv3 1/1] net: forcedeth: add xmit_more support Zhu Yanjun
2019-10-29 17:32 ` Jakub Kicinski [this message]
2019-10-30 4:18 ` Zhu Yanjun
2019-10-30 4:14 ` David Miller
2019-10-30 4:30 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029103244.3139a6aa@cakuba.hsd1.ca.comcast.net \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rain.1986.08.12@gmail.com \
--cc=yanjun.zhu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox