From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4EDCA9EC3 for ; Tue, 29 Oct 2019 21:59:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57C662173E for ; Tue, 29 Oct 2019 21:59:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="qgkV77A9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726421AbfJ2V7Q (ORCPT ); Tue, 29 Oct 2019 17:59:16 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:33336 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbfJ2V7P (ORCPT ); Tue, 29 Oct 2019 17:59:15 -0400 Received: by mail-pl1-f195.google.com with SMTP id y8so8371454plk.0 for ; Tue, 29 Oct 2019 14:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DpN5YTXrp9hp71uxbnpmiOwzB6GTFkwG/3T4Kj5BrEM=; b=qgkV77A9tGs/sOv5qzKPxPbYxXbujKalYxznr/KJcAe6aHZXkpz2sB7b0GwaCBdIk5 3AwShV2aLjyJtqCJZqgIrvfLUdOfsdTOAyEBfQVvUPGmwf7VXSg3zyiZ+pVn2P1rBoOm 6nvgQ1Bcrgd79MPUNP7FKGx5ZYxjvd7ZEWwpK6R7K2HHKzpWhgCf2T11tuSaV8QLDB7o Xt2ksQZgxh1ThsQ6ZZmzq8HgpVWKu0jwtyGXC9xc+Sngf75prU0+zt7cuJgjTOpdXglL Ku52vyE+ow5Vwet0EDpMTyWeX7GSlMnL8UK9bxhJR2CvrlVSy0cbXnvz+bKysuAUrCUH dL7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DpN5YTXrp9hp71uxbnpmiOwzB6GTFkwG/3T4Kj5BrEM=; b=NtTlRC52v7aHzCWKtziPh/i/pzFKaj2z5rjlPsBvASWP4uuVaHx5vweTfBFXqmTW/B tNLjWQonj0yBCT4MTXhdrQcalzIFK3iujqSBupplEtITOXomrIso+8WmMgmC2KspgY5J lJZ0SBI15Tp1RcJM7OgzXo4LQXNblmd27f4QEENrUZqXOMG1BAdU/gPnO959p+ZS4kOm LYKggKS7IRgl/10pmml4NUCvhRa2+MUPKIecixVRyssRqUTbTY5242DaevZYiWcFRqbS ISrpv04PUZmI29yWuGiuVtwtS+paByPCjJkLTFGyNM09yuqw6f1j1R2QVU6yEmIpltJF t/FA== X-Gm-Message-State: APjAAAWFh4dmzPxo1dnijhhq5vmmxh4IrAzdWpLZxjWZeepgZ+ycTdH8 leCvrrnbh+c/JyDr3U9XQPRNyw== X-Google-Smtp-Source: APXvYqwNwn6ag5YudPb6b9eKtM6k1ulB0HqZ/o7WfnbelP889IRTVFDRbkId8DAH5pLmscTc97rObA== X-Received: by 2002:a17:902:988d:: with SMTP id s13mr915958plp.335.1572386354831; Tue, 29 Oct 2019 14:59:14 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j10sm85753pfn.128.2019.10.29.14.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 14:59:14 -0700 (PDT) Date: Tue, 29 Oct 2019 14:59:05 -0700 From: Stephen Hemminger To: Haiyang Zhang Cc: Jakub Kicinski , "sashal@kernel.org" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , KY Srinivasan , Stephen Hemminger , "olaf@aepfle.de" , vkuznets , "davem@davemloft.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next, 3/4] hv_netvsc: Add XDP support Message-ID: <20191029145905.414f86c3@hermes.lan> In-Reply-To: References: <1572296801-4789-1-git-send-email-haiyangz@microsoft.com> <1572296801-4789-4-git-send-email-haiyangz@microsoft.com> <20191028143322.45d81da4@cakuba.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 29 Oct 2019 19:17:25 +0000 Haiyang Zhang wrote: > > -----Original Message----- > > From: Jakub Kicinski > > Sent: Monday, October 28, 2019 5:33 PM > > To: Haiyang Zhang > > Cc: sashal@kernel.org; linux-hyperv@vger.kernel.org; > > netdev@vger.kernel.org; KY Srinivasan ; Stephen > > Hemminger ; olaf@aepfle.de; vkuznets > > ; davem@davemloft.net; linux- > > kernel@vger.kernel.org > > Subject: Re: [PATCH net-next, 3/4] hv_netvsc: Add XDP support > > > > On Mon, 28 Oct 2019 21:07:04 +0000, Haiyang Zhang wrote: > > > This patch adds support of XDP in native mode for hv_netvsc driver, and > > > transparently sets the XDP program on the associated VF NIC as well. > > > > > > XDP program cannot run with LRO (RSC) enabled, so you need to disable > > LRO > > > before running XDP: > > > ethtool -K eth0 lro off > > > > > > XDP actions not yet supported: > > > XDP_TX, XDP_REDIRECT > > > > I don't think we want to merge support without at least XDP_TX these > > days.. > Thanks for your detailed comments -- > I'm working on the XDP_TX... > > > > > And without the ability to prepend headers this may be the least > > complete initial XDP implementation we've seen :( > The RNDIS packet buffer received by netvsc doesn't have a head room, but I'm > considering copy the packets to the page buffer, with a head room space > reserved for XDP. There is a small amount of headroom available by reusing the RNDIS header and packet space. Looks like 40 bytes or so.