* [PATCH net-next] vxlan: drop "vxlan" parameter in vxlan_fdb_alloc()
@ 2019-10-29 20:57 Guillaume Nault
2019-10-30 12:27 ` Simon Horman
2019-10-31 0:42 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Guillaume Nault @ 2019-10-29 20:57 UTC (permalink / raw)
To: David Miller, Jakub Kicinski; +Cc: netdev, Roopa Prabhu
This parameter has never been used.
Signed-off-by: Guillaume Nault <gnault@redhat.com>
---
drivers/net/vxlan.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 3d9bcc957f7d..5ffea8e34771 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -793,8 +793,7 @@ static int vxlan_gro_complete(struct sock *sk, struct sk_buff *skb, int nhoff)
return eth_gro_complete(skb, nhoff + sizeof(struct vxlanhdr));
}
-static struct vxlan_fdb *vxlan_fdb_alloc(struct vxlan_dev *vxlan,
- const u8 *mac, __u16 state,
+static struct vxlan_fdb *vxlan_fdb_alloc(const u8 *mac, __u16 state,
__be32 src_vni, __u16 ndm_flags)
{
struct vxlan_fdb *f;
@@ -835,7 +834,7 @@ static int vxlan_fdb_create(struct vxlan_dev *vxlan,
return -ENOSPC;
netdev_dbg(vxlan->dev, "add %pM -> %pIS\n", mac, ip);
- f = vxlan_fdb_alloc(vxlan, mac, state, src_vni, ndm_flags);
+ f = vxlan_fdb_alloc(mac, state, src_vni, ndm_flags);
if (!f)
return -ENOMEM;
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] vxlan: drop "vxlan" parameter in vxlan_fdb_alloc()
2019-10-29 20:57 [PATCH net-next] vxlan: drop "vxlan" parameter in vxlan_fdb_alloc() Guillaume Nault
@ 2019-10-30 12:27 ` Simon Horman
2019-10-31 0:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2019-10-30 12:27 UTC (permalink / raw)
To: Guillaume Nault; +Cc: David Miller, Jakub Kicinski, netdev, Roopa Prabhu
On Tue, Oct 29, 2019 at 09:57:10PM +0100, Guillaume Nault wrote:
> This parameter has never been used.
>
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
> ---
> drivers/net/vxlan.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 3d9bcc957f7d..5ffea8e34771 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -793,8 +793,7 @@ static int vxlan_gro_complete(struct sock *sk, struct sk_buff *skb, int nhoff)
> return eth_gro_complete(skb, nhoff + sizeof(struct vxlanhdr));
> }
>
> -static struct vxlan_fdb *vxlan_fdb_alloc(struct vxlan_dev *vxlan,
> - const u8 *mac, __u16 state,
> +static struct vxlan_fdb *vxlan_fdb_alloc(const u8 *mac, __u16 state,
> __be32 src_vni, __u16 ndm_flags)
> {
> struct vxlan_fdb *f;
> @@ -835,7 +834,7 @@ static int vxlan_fdb_create(struct vxlan_dev *vxlan,
> return -ENOSPC;
>
> netdev_dbg(vxlan->dev, "add %pM -> %pIS\n", mac, ip);
> - f = vxlan_fdb_alloc(vxlan, mac, state, src_vni, ndm_flags);
> + f = vxlan_fdb_alloc(mac, state, src_vni, ndm_flags);
> if (!f)
> return -ENOMEM;
>
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] vxlan: drop "vxlan" parameter in vxlan_fdb_alloc()
2019-10-29 20:57 [PATCH net-next] vxlan: drop "vxlan" parameter in vxlan_fdb_alloc() Guillaume Nault
2019-10-30 12:27 ` Simon Horman
@ 2019-10-31 0:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-10-31 0:42 UTC (permalink / raw)
To: gnault; +Cc: jakub.kicinski, netdev, roopa
From: Guillaume Nault <gnault@redhat.com>
Date: Tue, 29 Oct 2019 21:57:10 +0100
> This parameter has never been used.
>
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-31 0:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-29 20:57 [PATCH net-next] vxlan: drop "vxlan" parameter in vxlan_fdb_alloc() Guillaume Nault
2019-10-30 12:27 ` Simon Horman
2019-10-31 0:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).