From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D43CA9EC5 for ; Wed, 30 Oct 2019 15:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 510F0217D9 for ; Wed, 30 Oct 2019 15:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728243AbfJ3Pxx (ORCPT ); Wed, 30 Oct 2019 11:53:53 -0400 Received: from www62.your-server.de ([213.133.104.62]:42368 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728175AbfJ3Px2 (ORCPT ); Wed, 30 Oct 2019 11:53:28 -0400 Received: from [2a02:120b:2c12:c120:71a0:62dd:894c:fd0e] (helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iPqHe-000671-MG; Wed, 30 Oct 2019 16:53:18 +0100 Date: Wed, 30 Oct 2019 16:53:18 +0100 From: Daniel Borkmann To: Alexei Starovoitov Cc: davem@davemloft.net, netdev@vger.kernel.org, bpf@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH bpf-next] bpf: Enforce 'return 0' in BTF-enabled raw_tp programs Message-ID: <20191030155318.GB2675@pc-63.home> References: <20191029032426.1206762-1-ast@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029032426.1206762-1-ast@kernel.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25618/Wed Oct 30 09:54:22 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Oct 28, 2019 at 08:24:26PM -0700, Alexei Starovoitov wrote: > The return value of raw_tp programs is ignored by __bpf_trace_run() > that calls them. The verifier also allows any value to be returned. > For BTF-enabled raw_tp lets enforce 'return 0', so that return value > can be used for something in the future. > > Signed-off-by: Alexei Starovoitov Applied, thanks!