From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC733CA9ECB for ; Thu, 31 Oct 2019 01:04:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCEDF2080F for ; Thu, 31 Oct 2019 01:04:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726501AbfJaBEE (ORCPT ); Wed, 30 Oct 2019 21:04:04 -0400 Received: from www62.your-server.de ([213.133.104.62]:43076 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbfJaBED (ORCPT ); Wed, 30 Oct 2019 21:04:03 -0400 Received: from 38.249.197.178.dynamic.dsl-lte-bonding.lssmb00p-msn.res.cust.swisscom.ch ([178.197.249.38] helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iPysU-0000PM-L8; Thu, 31 Oct 2019 02:03:55 +0100 Date: Thu, 31 Oct 2019 02:03:54 +0100 From: Daniel Borkmann To: Alexei Starovoitov Cc: davem@davemloft.net, jolsa@redhat.com, netdev@vger.kernel.org, bpf@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH bpf-next] bpf: Fix bpf jit kallsym access Message-ID: <20191031010354.GA11351@pc-63.home> References: <20191030233019.1187404-1-ast@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030233019.1187404-1-ast@kernel.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25618/Wed Oct 30 09:54:22 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Oct 30, 2019 at 04:30:19PM -0700, Alexei Starovoitov wrote: > Jiri reported crash when JIT is on, but net.core.bpf_jit_kallsyms is off. > bpf_prog_kallsyms_find() was skipping addr->bpf_prog resolution > logic in oops and stack traces. That's incorrect. > It should only skip addr->name resolution for 'cat /proc/kallsyms'. > That's what bpf_jit_kallsyms and bpf_jit_harden protect. > > Reported-by: Jiri Olsa > Signed-off-by: Alexei Starovoitov > Fixes: 3dec541b2e63 ("bpf: Add support for BTF pointers to x86 JIT") ACK makes sense, applied, thanks!