From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 361AFCA9ED3 for ; Mon, 4 Nov 2019 16:29:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AD5320848 for ; Mon, 4 Nov 2019 16:29:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="PfsYHrTR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728336AbfKDQ3o (ORCPT ); Mon, 4 Nov 2019 11:29:44 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33426 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728321AbfKDQ3n (ORCPT ); Mon, 4 Nov 2019 11:29:43 -0500 Received: by mail-pg1-f194.google.com with SMTP id u23so11624595pgo.0 for ; Mon, 04 Nov 2019 08:29:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=yDJzuHaFrgDE1koaL4VlaTE201wYefd3OwCvYO8ysEU=; b=PfsYHrTRK/P8+qRQn8NZ79YZ2CjKL1sum8VuGgpn8h9BLbBW7CZql+HC8UWdA7p2+L cEyGOwBWZaqjUkm/0Z6U9XtvNhIbzziY8UCWrXTGhoLQf+h7WUIiT0sV91wgiucBFShk jqkhbQqemKwmthXRxZXjY0dY99BQsVkF6mDP112JH0PCgTrDkL/OE8I/V8DWscn8eEVy 9YCihiMSS72wFW5oL56XBsUVgjtU0b+LdyvpIHLSPsPnOx6KsaQ+HaexF8gAdo7tcHub EKZqSzm8zCniN6MaVWfVHf0ValeVg+vB1PqjdGzIIU00morL98KbP1Wtww6fQ+SahL2c VPuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=yDJzuHaFrgDE1koaL4VlaTE201wYefd3OwCvYO8ysEU=; b=NEzd68++sB37/BA+nkDiXw07LpuGvRohpxq1EkGB4XBkvHG+7L+v2J1Xx1BbrdD/3D YcNf1BRFFonarRg/MyoXibbj8LAiQyoodeqEuF0L1v4XCOdf7GWgq0ixPx7mL1iro3bN p/KJEEH10UPBPmZfYmZn1KZ25ljZg38TGMi7/2rWEP5GZUg9HwzVj9n2lIfo+ShhWX9E tzl6gNZX5fFgWFJRbQ3wk7DOulF9fLPLHQlvNOsz1UPJgNPPR/fsSiGCgfoYfcWOZ+6z D5Kjqr/3kbG76DCVLZ/l6z2wlnZsRXDm3MDVstD2ANb4X3YLqEJ0kBG4GhisqRpriMIs mVCA== X-Gm-Message-State: APjAAAUEqEvDt4l6DcpkwJRw87kpzPiztd63LG9OU/LgR9cLN72olu2G A/0CL1iV3Qd5723TyFEdvH3eMQ== X-Google-Smtp-Source: APXvYqwpiP2aKfBZwiONDK30yJFr79JwBMg1oHg1YfDywuN4GIzwpS1bI4ZA7pGHqCSOKyoITCVseg== X-Received: by 2002:a17:90a:5d0f:: with SMTP id s15mr36068769pji.90.1572884982928; Mon, 04 Nov 2019 08:29:42 -0800 (PST) Received: from cakuba.netronome.com ([2601:646:8e00:e18::4]) by smtp.gmail.com with ESMTPSA id 6sm17328038pfz.156.2019.11.04.08.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 08:29:42 -0800 (PST) Date: Mon, 4 Nov 2019 08:29:38 -0800 From: Jakub Kicinski To: Dan Carpenter Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , netdev@vger.kernel.org, bpf@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH bpf] bpf: offload: unlock on error in bpf_offload_dev_create() Message-ID: <20191104082938.351c1f07@cakuba.netronome.com> In-Reply-To: <20191104091536.GB31509@mwanda> References: <20191104091536.GB31509@mwanda> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 4 Nov 2019 12:15:36 +0300, Dan Carpenter wrote: > We need to drop the bpf_devs_lock on error before returning. > > Fixes: 9fd7c5559165 ("bpf: offload: aggregate offloads per-device") > Signed-off-by: Dan Carpenter Acked-by: Jakub Kicinski