From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Li Zefan <lizefan@huawei.com>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Song Liu <liu.song.a23@gmail.com>,
cgroups@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Jens Axboe <axboe@kernel.dk>,
"David S. Miller" <davem@davemloft.net>,
linux-block@vger.kernel.org, bpf@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] kernfs: Convert to u64 id
Date: Mon, 4 Nov 2019 08:59:01 -0500 [thread overview]
Message-ID: <20191104085901.06035a26@grimm.local.home> (raw)
In-Reply-To: <20191104084520.398584-2-namhyung@kernel.org>
On Mon, 4 Nov 2019 17:45:19 +0900
Namhyung Kim <namhyung@kernel.org> wrote:
> From: Tejun Heo <tj@kernel.org>
>
> The kernfs_id was an union type sharing a 64bit id with 32bit ino +
> gen. But it resulted in using 32bit inode even on 64bit systems.
> Also dealing with an union is annoying especially if you just want to
> use a single id.
>
> Thus let's get rid of the kernfs_node_id type and use u64 directly.
> The upper 32bit is used for gen and lower is for ino on 32bit systems.
> The kernfs_id_ino() and kernfs_id_gen() helpers will take care of the
> bit handling depends on the system word size.
>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Martin KaFai Lau <kafai@fb.com>
> Cc: Song Liu <songliubraving@fb.com>
> Cc: Yonghong Song <yhs@fb.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-block@vger.kernel.org
> Cc: bpf@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Tejun Heo <tj@kernel.org>
> [namhyung: fix build error in bpf_get_current_cgroup_id()]
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> fs/kernfs/dir.c | 36 ++++++++-----
> fs/kernfs/file.c | 4 +-
> fs/kernfs/inode.c | 4 +-
> fs/kernfs/kernfs-internal.h | 2 -
> fs/kernfs/mount.c | 92 +++++++++++++++++++-------------
> include/linux/cgroup.h | 17 +++---
> include/linux/exportfs.h | 5 ++
> include/linux/kernfs.h | 47 +++++++++-------
> include/trace/events/writeback.h | 92 ++++++++++++++++----------------
I only looked at the above file, and didn't see anything bad about it.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> kernel/bpf/helpers.c | 2 +-
> kernel/cgroup/cgroup.c | 5 +-
> kernel/trace/blktrace.c | 66 +++++++++++------------
> net/core/filter.c | 4 +-
> 13 files changed, 207 insertions(+), 169 deletions(-)
next prev parent reply other threads:[~2019-11-04 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191104084520.398584-1-namhyung@kernel.org>
2019-11-04 8:45 ` [PATCH v2 1/2] kernfs: Convert to u64 id Namhyung Kim
2019-11-04 13:59 ` Steven Rostedt [this message]
2019-11-04 8:45 ` [PATCH v2 2/2] cgroup: Use 64bit id from kernfs Namhyung Kim
2019-11-04 18:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104085901.06035a26@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=kafai@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liu.song.a23@gmail.com \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=songliubraving@fb.com \
--cc=tj@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).