From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "dsahern@gmail.com" <dsahern@gmail.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"sbrivio@redhat.com" <sbrivio@redhat.com>,
"nikolay@cumulusnetworks.com" <nikolay@cumulusnetworks.com>,
Jiri Pirko <jiri@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"sd@queasysnail.net" <sd@queasysnail.net>,
Ariel Levkovich <lariel@mellanox.com>
Subject: Re: [PATCH net-next v2 0/3] VGT+ support
Date: Tue, 5 Nov 2019 13:55:36 -0800 [thread overview]
Message-ID: <20191105135536.5da90316@cakuba.netronome.com> (raw)
In-Reply-To: <3da1761ec4a15db87800a180c521bbc7bf01a5b2.camel@mellanox.com>
On Tue, 5 Nov 2019 20:10:02 +0000, Saeed Mahameed wrote:
> > > > Now if the only remaining problem is the uAPI, we can minimize
> > > > kernel impact or even make no kernel changes at all, only ip
> > > > route2 and drivers, by reusing the current set_vf_vlan_ndo.
> > >
> > > And this caught my eye as well -- iproute2 does not need the
> > > baggage either.
> > >
> > > Is there any reason this continued support for legacy sriov can
> > > not be done out of tree?
> >
> > Exactly. Moving to upstream is only valuable if it doesn't require
> > brining all the out-of-tree baggage.
>
> this baggage is a very essential part for eth sriov, it is a missing
> feature in both switchdev mode (bridge offloads) and legacy.
AFAIK from uAPI perspective nothing is missing in switchdev mode.
> Guys, I need to know my options here and make some effort assessment.
>
> 1) implement bridge offloads: months of development, years for
> deployment and migration
> 2) Close this gap in legacy mode: days.
>
> I am all IN for bridge offloads, but you have to understand why i pick
> 2, not because it is cheaper, but because it is more realistic for my
> current users. Saying no to this just because switchdev mode is the de
> facto standard isn't fair and there should be an active clear
> transition plan, with something available to work with ... not just
> ideas.
I understand your perspective. It is cheaper for you.
> Your claims are valid only when we are truly ready for migration. we
> are simply not and no one has a clear plan in the horizon, so i don't
> get this total freeze attitude of legacy mode,
There will never be any L2 plan unless we say no to legacy extensions.
> it should be just like ethtool we want to to replace it but we know
> we are not there yet, so we carefully add only necessary things with
> lots of auditing, same should go here.
Worked out amazingly for ethtool, right?
next prev parent reply other threads:[~2019-11-05 21:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 19:47 [PATCH net-next v2 0/3] VGT+ support Ariel Levkovich
2019-10-31 19:47 ` [PATCH net-next v2 1/3] net: Support querying specific VF properties Ariel Levkovich
2019-10-31 19:47 ` [PATCH net-next v2 2/3] net: Add SRIOV VGT+ support Ariel Levkovich
2019-10-31 19:47 ` [PATCH net-next v2 3/3] net/mlx5: " Ariel Levkovich
2019-10-31 20:31 ` [PATCH net-next v2 0/3] " David Miller
2019-10-31 22:20 ` Ariel Levkovich
2019-10-31 22:58 ` David Miller
2019-11-01 14:55 ` Ariel Levkovich
2019-11-01 0:23 ` Jakub Kicinski
[not found] ` <8d7db56c-376a-d809-4a65-bfc2baf3254f@mellanox.com>
2019-11-01 21:28 ` Saeed Mahameed
2019-11-02 0:21 ` Jakub Kicinski
2019-11-05 1:38 ` Saeed Mahameed
2019-11-05 1:47 ` David Ahern
2019-11-05 2:35 ` Jakub Kicinski
2019-11-05 20:10 ` Saeed Mahameed
2019-11-05 21:55 ` Jakub Kicinski [this message]
2019-11-05 22:52 ` Saeed Mahameed
2019-11-05 23:10 ` Jakub Kicinski
2019-11-05 23:48 ` Saeed Mahameed
2019-11-06 1:38 ` Jakub Kicinski
2019-11-06 22:21 ` Saeed Mahameed
2019-11-07 10:24 ` Jiri Pirko
2019-11-13 22:55 ` Keller, Jacob E
2019-11-14 2:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105135536.5da90316@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=dsahern@gmail.com \
--cc=jiri@mellanox.com \
--cc=lariel@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=saeedm@mellanox.com \
--cc=sbrivio@redhat.com \
--cc=sd@queasysnail.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).