From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: stephen@networkplumber.org, dsahern@gmail.com,
oss-drivers@netronome.com, netdev@vger.kernel.org,
Jiri Pirko <jiri@mellanox.com>,
Arkadi Sharshevsky <arkadis@mellanox.com>
Subject: Re: [PATCH iproute2] devlink: require resource parameters
Date: Wed, 6 Nov 2019 09:12:26 +0100 [thread overview]
Message-ID: <20191106081226.GA2112@nanopsycho> (raw)
In-Reply-To: <20191105211336.10075-1-jakub.kicinski@netronome.com>
Tue, Nov 05, 2019 at 10:13:36PM CET, jakub.kicinski@netronome.com wrote:
>If devlink resource set parameters are not provided it crashes:
>$ devlink resource set netdevsim/netdevsim0
>Segmentation fault (core dumped)
>
>This is because even though DL_OPT_RESOURCE_PATH and
>DL_OPT_RESOURCE_SIZE are passed as o_required, the validation
>table doesn't contain a relevant string.
>
>Fixes: 8cd644095842 ("devlink: Add support for devlink resource abstraction")
>Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>--
>CC: Jiri Pirko <jiri@mellanox.com>
>CC: Arkadi Sharshevsky <arkadis@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2019-11-06 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 21:13 [PATCH iproute2] devlink: require resource parameters Jakub Kicinski
2019-11-06 8:12 ` Jiri Pirko [this message]
2019-11-08 4:38 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106081226.GA2112@nanopsycho \
--to=jiri@resnulli.us \
--cc=arkadis@mellanox.com \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).