* [PATCH v2] nfc: netlink: fix double device reference drop
@ 2019-11-07 6:29 Pan Bian
2019-11-07 8:18 ` Johan Hovold
2019-11-07 23:24 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Pan Bian @ 2019-11-07 6:29 UTC (permalink / raw)
To: David S. Miller, Johannes Berg, Steve Winslow, Young Xiao,
Allison Randal, Michal Kubecek, Andrey Konovalov, Thomas Gleixner
Cc: netdev, linux-kernel, Pan Bian
The function nfc_put_device(dev) is called twice to drop the reference
to dev when there is no associated local llcp. Remove one of them to fix
the bug.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
v2: change subject of the patch
---
net/nfc/netlink.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 17e6ca62f1be..afde0d763039 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -1099,7 +1099,6 @@ static int nfc_genl_llc_set_params(struct sk_buff *skb, struct genl_info *info)
local = nfc_llcp_find_local(dev);
if (!local) {
- nfc_put_device(dev);
rc = -ENODEV;
goto exit;
}
@@ -1159,7 +1158,6 @@ static int nfc_genl_llc_sdreq(struct sk_buff *skb, struct genl_info *info)
local = nfc_llcp_find_local(dev);
if (!local) {
- nfc_put_device(dev);
rc = -ENODEV;
goto exit;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] nfc: netlink: fix double device reference drop
2019-11-07 6:29 [PATCH v2] nfc: netlink: fix double device reference drop Pan Bian
@ 2019-11-07 8:18 ` Johan Hovold
2019-11-07 23:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2019-11-07 8:18 UTC (permalink / raw)
To: Pan Bian
Cc: David S. Miller, Johannes Berg, Steve Winslow, Young Xiao,
Allison Randal, Michal Kubecek, Andrey Konovalov, Thomas Gleixner,
netdev, linux-kernel
On Thu, Nov 07, 2019 at 02:29:50PM +0800, Pan Bian wrote:
> The function nfc_put_device(dev) is called twice to drop the reference
> to dev when there is no associated local llcp. Remove one of them to fix
> the bug.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
> v2: change subject of the patch
> ---
> net/nfc/netlink.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Johan Hovold <johan@kernel.org>
In the future, please try to track down the commits introducing the bugs
you fix. That will help not only reviewers, but also the stable
maintainers.
In this case you could have added:
Fixes: 52feb444a903 ("NFC: Extend netlink interface for LTO, RW, and MIUX parameters support")
Fixes: d9b8d8e19b07 ("NFC: llcp: Service Name Lookup netlink interface")
> diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
> index 17e6ca62f1be..afde0d763039 100644
> --- a/net/nfc/netlink.c
> +++ b/net/nfc/netlink.c
> @@ -1099,7 +1099,6 @@ static int nfc_genl_llc_set_params(struct sk_buff *skb, struct genl_info *info)
>
> local = nfc_llcp_find_local(dev);
> if (!local) {
> - nfc_put_device(dev);
> rc = -ENODEV;
> goto exit;
> }
> @@ -1159,7 +1158,6 @@ static int nfc_genl_llc_sdreq(struct sk_buff *skb, struct genl_info *info)
>
> local = nfc_llcp_find_local(dev);
> if (!local) {
> - nfc_put_device(dev);
> rc = -ENODEV;
> goto exit;
> }
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] nfc: netlink: fix double device reference drop
2019-11-07 6:29 [PATCH v2] nfc: netlink: fix double device reference drop Pan Bian
2019-11-07 8:18 ` Johan Hovold
@ 2019-11-07 23:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-11-07 23:24 UTC (permalink / raw)
To: bianpan2016
Cc: johannes.berg, swinslow, 92siuyang, allison, mkubecek, andreyknvl,
tglx, netdev, linux-kernel
From: Pan Bian <bianpan2016@163.com>
Date: Thu, 7 Nov 2019 14:29:50 +0800
> The function nfc_put_device(dev) is called twice to drop the reference
> to dev when there is no associated local llcp. Remove one of them to fix
> the bug.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
> v2: change subject of the patch
Applied, with Fixes: tags added, and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-07 23:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-07 6:29 [PATCH v2] nfc: netlink: fix double device reference drop Pan Bian
2019-11-07 8:18 ` Johan Hovold
2019-11-07 23:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).