* [PATCH net-next] mlxsw: spectrum: Fix error return code in mlxsw_sp_port_module_info_init()
@ 2019-11-06 14:52 Wei Yongjun
2019-11-07 10:46 ` Jiri Pirko
2019-11-07 23:13 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2019-11-06 14:52 UTC (permalink / raw)
To: Jiri Pirko, Ido Schimmel; +Cc: Wei Yongjun, netdev, kernel-janitors
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 4a7f970f1240 ("mlxsw: spectrum: Replace port_to_module array with array of structs")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index ea4cc2aa99e0..838c014f6ed1 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -4079,8 +4079,10 @@ static int mlxsw_sp_port_module_info_init(struct mlxsw_sp *mlxsw_sp)
mlxsw_sp->port_mapping[i] = kmemdup(&port_mapping,
sizeof(port_mapping),
GFP_KERNEL);
- if (!mlxsw_sp->port_mapping[i])
+ if (!mlxsw_sp->port_mapping[i]) {
+ err = -ENOMEM;
goto err_port_module_info_dup;
+ }
}
return 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] mlxsw: spectrum: Fix error return code in mlxsw_sp_port_module_info_init()
2019-11-06 14:52 [PATCH net-next] mlxsw: spectrum: Fix error return code in mlxsw_sp_port_module_info_init() Wei Yongjun
@ 2019-11-07 10:46 ` Jiri Pirko
2019-11-07 23:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2019-11-07 10:46 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Jiri Pirko, Ido Schimmel, netdev, kernel-janitors
Wed, Nov 06, 2019 at 03:52:31PM CET, weiyongjun1@huawei.com wrote:
>Fix to return negative error code -ENOMEM from the error handling
>case instead of 0, as done elsewhere in this function.
>
>Fixes: 4a7f970f1240 ("mlxsw: spectrum: Replace port_to_module array with array of structs")
>Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] mlxsw: spectrum: Fix error return code in mlxsw_sp_port_module_info_init()
2019-11-06 14:52 [PATCH net-next] mlxsw: spectrum: Fix error return code in mlxsw_sp_port_module_info_init() Wei Yongjun
2019-11-07 10:46 ` Jiri Pirko
@ 2019-11-07 23:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-11-07 23:13 UTC (permalink / raw)
To: weiyongjun1; +Cc: jiri, idosch, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 6 Nov 2019 14:52:31 +0000
> Fix to return negative error code -ENOMEM from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 4a7f970f1240 ("mlxsw: spectrum: Replace port_to_module array with array of structs")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-07 23:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-06 14:52 [PATCH net-next] mlxsw: spectrum: Fix error return code in mlxsw_sp_port_module_info_init() Wei Yongjun
2019-11-07 10:46 ` Jiri Pirko
2019-11-07 23:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).