From: Andrew Lunn <andrew@lunn.ch>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] dpaa2-eth: add ethtool MAC counters
Date: Thu, 7 Nov 2019 14:01:44 +0100 [thread overview]
Message-ID: <20191107130144.GC22978@lunn.ch> (raw)
In-Reply-To: <VI1PR0402MB280021AE88E253270FEEC02CE0780@VI1PR0402MB2800.eurprd04.prod.outlook.com>
> Anyhow, I'll add this to the list of things to improve in the fw :)
Hi Ioana
I also later thought about snapshotting. Often the hardware supports
taking an atomic copy of all the statistics. You can then read back
the copy, knowing that the values should be consistent. None get
incremented while you read individual counters.
Something else you can consider adding to the firmware.
Andrew
prev parent reply other threads:[~2019-11-07 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 0:49 [PATCH net-next] dpaa2-eth: add ethtool MAC counters Ioana Ciornei
2019-11-07 1:47 ` Andrew Lunn
2019-11-07 7:34 ` Ioana Ciornei
2019-11-07 13:01 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107130144.GC22978@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).