From: David Miller <davem@davemloft.net>
To: manishc@marvell.com
Cc: netdev@vger.kernel.org, aelior@marvell.com, skalluru@marvell.com
Subject: Re: [PATCH net 1/1] qede: fix NULL pointer deref in __qede_remove()
Date: Fri, 08 Nov 2019 14:08:41 -0800 (PST) [thread overview]
Message-ID: <20191108.140841.647087207980890676.davem@davemloft.net> (raw)
In-Reply-To: <20191108104230.9833-1-manishc@marvell.com>
From: Manish Chopra <manishc@marvell.com>
Date: Fri, 8 Nov 2019 02:42:30 -0800
> While rebooting the system with SR-IOV vfs enabled leads
> to below crash due to recurrence of __qede_remove() on the VF
> devices (first from .shutdown() flow of the VF itself and
> another from PF's .shutdown() flow executing pci_disable_sriov())
>
> This patch adds a safeguard in __qede_remove() flow to fix this,
> so that driver doesn't attempt to remove "already removed" devices.
...
> Signed-off-by: Manish Chopra <manishc@marvell.com>
> Signed-off-by: Ariel Elior <aelior@marvell.com>
> Signed-off-by: Sudarsana Kalluru <skalluru@marvell.com>
There should probably be a cleaner, more structural, way to prevent
this sequence.
But for now this fix is good enough.
Applied and queued up for -stable.
prev parent reply other threads:[~2019-11-08 22:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 10:42 [PATCH net 1/1] qede: fix NULL pointer deref in __qede_remove() Manish Chopra
2019-11-08 22:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108.140841.647087207980890676.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aelior@marvell.com \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).