From: kbuild test robot <lkp@intel.com>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
Tristram.Ha@microchip.com, UNGLinuxDriver@microchip.com,
kernel@pengutronix.de
Subject: Re: [PATCH v1 3/4] ksz: Add Microchip KSZ8863 SMI-DSA driver
Date: Sat, 9 Nov 2019 16:08:58 +0800 [thread overview]
Message-ID: <201911091627.4jlynWYJ%lkp@intel.com> (raw)
In-Reply-To: <20191107110030.25199-4-m.grzeschik@pengutronix.de>
Hi Michael,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net/master]
[also build test WARNING on v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Michael-Grzeschik/microchip-add-support-for-ksz88x3-driver-family/20191109-122140
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git a2582cdc32f071422e0197a6c59bd1235b426ce2
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-21-gb31adac-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:193:14: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] data @@ got nsigned long long [usertype] data @@
>> drivers/net/dsa/microchip/ksz8863.c:193:14: sparse: expected unsigned long long [usertype] data
>> drivers/net/dsa/microchip/ksz8863.c:193:14: sparse: got restricted __be64 [usertype]
drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
vim +184 drivers/net/dsa/microchip/ksz8863.c
172
173 static void ksz8863_r_table(struct ksz_device *dev, int table, u16 addr,
174 u64 *data)
175 {
176 u16 ctrl_addr;
177
178 ctrl_addr = IND_ACC_TABLE(table | TABLE_READ) | addr;
179
180 mutex_lock(&dev->alu_mutex);
181 ksz_write16(dev, REG_IND_CTRL_0, ctrl_addr);
182 ksz_read64(dev, REG_IND_DATA_HI, data);
183 mutex_unlock(&dev->alu_mutex);
> 184 *data = be64_to_cpu(*data);
185 }
186
187 static void ksz8863_w_table(struct ksz_device *dev, int table, u16 addr,
188 u64 data)
189 {
190 u16 ctrl_addr;
191
192 ctrl_addr = IND_ACC_TABLE(table) | addr;
> 193 data = cpu_to_be64(data);
194
195 mutex_lock(&dev->alu_mutex);
196 ksz_write64(dev, REG_IND_DATA_HI, data);
197 ksz_write16(dev, REG_IND_CTRL_0, ctrl_addr);
198 mutex_unlock(&dev->alu_mutex);
199 }
200
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
next prev parent reply other threads:[~2019-11-09 8:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 11:00 [PATCH v1 0/4] microchip: add support for ksz88x3 driver family Michael Grzeschik
2019-11-07 11:00 ` [PATCH v1 1/4] mdio-bitbang: add SMI0 mode support Michael Grzeschik
2019-11-07 15:42 ` Andrew Lunn
2019-12-18 16:29 ` [PATCH] mdio-bitbang: add support for lowlevel mdio read/write Michael Grzeschik
2019-12-19 20:39 ` Andrew Lunn
2019-12-19 22:01 ` Michael Grzeschik
2019-12-19 22:05 ` Florian Fainelli
2019-12-21 16:41 ` Andrew Lunn
2020-01-29 15:42 ` Michael Grzeschik
2020-01-29 15:53 ` Andrew Lunn
2020-01-29 21:48 ` Michael Grzeschik
2020-04-21 14:31 ` Michael Grzeschik
2019-11-07 11:00 ` [PATCH v1 2/4] net: tag: ksz: Add KSZ8863 tag code Michael Grzeschik
2019-11-07 15:44 ` Andrew Lunn
2019-11-07 11:00 ` [PATCH v1 3/4] ksz: Add Microchip KSZ8863 SMI-DSA driver Michael Grzeschik
2019-11-07 15:56 ` Andrew Lunn
2019-11-09 8:08 ` kbuild test robot [this message]
2019-11-07 11:00 ` [PATCH v1 4/4] dt-bindings: net: dsa: document additional Microchip KSZ8863/8873 switch Michael Grzeschik
2019-11-13 13:34 ` Rob Herring
2019-11-07 15:36 ` [PATCH v1 0/4] microchip: add support for ksz88x3 driver family Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911091627.4jlynWYJ%lkp@intel.com \
--to=lkp@intel.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel@pengutronix.de \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).