Re: [PATCH net-next v2 04/10] devlink: Support subdev HW address get

[Jiri Pirko <jiri@resnulli.us>]

Sat, Nov 09, 2019 at 07:13:30PM CET, parav@mellanox.com wrote:
>
>
>> From: Yuval Avnery <yuvalav@mellanox.com>
>> > > From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org>
>> > > Avnery <yuvalav@mellanox.com>
>> > > Subject: [PATCH net-next v2 04/10] devlink: Support subdev HW
>> > > address get
>> > >
>> > > Allow privileged user to get the HW address of a subdev.
>> > >
>> > > Example:
>> > >
>> > > $ devlink subdev show pci/0000:03:00.0/1
>> > > pci/0000:03:00.0/1: flavour pcivf pf 0 vf 0 port_index 1 hw_addr
>> > > 00:23:35:af:35:34
>> > >
>> > > $ devlink subdev show pci/0000:03:00.0/1 -pj {
>> > >     "subdev": {
>> > >         "pci/0000:03:00.0/1": {
>> > >             "flavour": "pcivf",
>> > >             "pf": 0,
>> > >             "vf": 0,
>> > >             "port_index": 1,
>> > >             "hw_addr": "00:23:35:af:35:34"
>> > I prefer this to be 'address' to match to 'ip link set address LLADDR'.
>> > That will make it consistent with rest of the iproute2/ip tool.
>> > So that users don't have to remember one mor keyword for the 'address'.
>> I think hw_addr is more accurate, and consistency doesn't exist here anyway.
>> We already have "ip link set vf set mac"
>> Address is not specific enough and can also mean IP address, while hw_addr
>> covers both ETH and IB
>Ok.
>
>Jiri,
>Do you want to wait to conclude the SF discussion, as we are discussing subdev there in confused state currently?

I belive that subdev is parallel to the discussion about SFs.