From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EFDEC43331 for ; Sun, 10 Nov 2019 15:51:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56E3E2077C for ; Sun, 10 Nov 2019 15:51:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="zIqEYiIY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726927AbfKJPvo (ORCPT ); Sun, 10 Nov 2019 10:51:44 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:59024 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726723AbfKJPvo (ORCPT ); Sun, 10 Nov 2019 10:51:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ks0Y+EMdxAKMqER9RztKPCqZPjO0iwkL4xEyT2291jU=; b=zIqEYiIYlKlKJC3BPsE671hMZK eKo8P6D1M9hBiJakIjE8OobCBf3SD7WnS8FNs1iZ8HLSSyVilGGo2+yYJmUlSo4oFydtqS7+dX7XK j7HqierpSgc1XW5GSY8GdcbtybQrnRc738HSXXJE0Qi7pF9e9insd/C8X5zXhP4KsmTs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iTpV7-0006kb-Bd; Sun, 10 Nov 2019 16:51:41 +0100 Date: Sun, 10 Nov 2019 16:51:41 +0100 From: Andrew Lunn To: Iwan R Timmer Cc: netdev@vger.kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Subject: Re: [PATCH net-next v3 1/2] net: dsa: mv88e6xxx: Split monitor port configuration Message-ID: <20191110155141.GA25889@lunn.ch> References: <20191107211114.106310-1-irtimmer@gmail.com> <20191107211114.106310-2-irtimmer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107211114.106310-2-irtimmer@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Nov 07, 2019 at 10:11:13PM +0100, Iwan R Timmer wrote: > Separate the configuration of the egress and ingress monitor port. > This allows the port mirror functionality to do ingress and egress > port mirroring to separate ports. Hi Iwan Thanks for the enum, it is much more readable. Reviewed-by: Andrew Lunn Andrew