From: Andrew Lunn <andrew@lunn.ch>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: brouer@redhat.com, lorenzo@kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: Regression in mvneta with XDP patches
Date: Mon, 11 Nov 2019 16:05:53 +0100 [thread overview]
Message-ID: <20191111150553.GC1105@lunn.ch> (raw)
In-Reply-To: <20191111143352.GA2698@apalos.home>
On Mon, Nov 11, 2019 at 04:33:52PM +0200, Ilias Apalodimas wrote:
> Hi Andrew,
>
> On Mon, Nov 11, 2019 at 02:46:15PM +0100, Andrew Lunn wrote:
> > Hi Lorenzo, Jesper, Ilias
> >
> > I just found that the XDP patches to mvneta have caused a regression.
> >
> > This one breaks networking:
>
> Thaks for the report.
> Looking at the DTS i can see 'buffer-manager' in it. The changes we made were
> for the driver path software buffer manager.
> Can you confirm which one your hardware uses?
Hi Ilias
Ah, interesting.
# CONFIG_MVNETA_BM_ENABLE is not set
So in fact it is not being compiled in, so should be falling back to
software buffer manager.
If i do enable it, then it works. So we are in a corner cases you
probably never tested. Requested by DT, but not actually available.
Andrew
next prev parent reply other threads:[~2019-11-11 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 13:46 Regression in mvneta with XDP patches Andrew Lunn
2019-11-11 14:33 ` Ilias Apalodimas
2019-11-11 15:05 ` Andrew Lunn [this message]
2019-11-11 15:14 ` Lorenzo Bianconi
2019-11-11 15:45 ` Andrew Lunn
2019-11-11 15:15 ` Ilias Apalodimas
2019-11-11 14:37 ` Lorenzo Bianconi
2019-11-11 15:09 ` Andrew Lunn
2019-11-11 15:12 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111150553.GC1105@lunn.ch \
--to=andrew@lunn.ch \
--cc=brouer@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).