From: Steven Rostedt <rostedt@goodmis.org>
To: Tony Lu <tonylu@linux.alibaba.com>
Cc: mingo@redhat.com, sanagi.koki@jp.fujitsu.co, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH] net: add missing semicolon in net_dev_template
Date: Mon, 11 Nov 2019 18:12:28 -0500 [thread overview]
Message-ID: <20191111181228.49396467@gandalf.local.home> (raw)
In-Reply-To: <20191111141752.31655-1-tonylu@linux.alibaba.com>
On Mon, 11 Nov 2019 22:17:53 +0800
Tony Lu <tonylu@linux.alibaba.com> wrote:
> This patch adds missing semicolon in the end of net_dev_template.
>
> Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> ---
> include/trace/events/net.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/net.h b/include/trace/events/net.h
> index 2399073c3afc..3b28843652d2 100644
> --- a/include/trace/events/net.h
> +++ b/include/trace/events/net.h
> @@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,
>
> TP_printk("dev=%s skbaddr=%p len=%u",
> __get_str(name), __entry->skbaddr, __entry->len)
> -)
> +);
Actually, we are thinking of making a sweeping patch set to remove all
these semicolons, as they are not needed, and would also allow more
flexible processing of the trace event macros.
-- Steve
>
> DEFINE_EVENT(net_dev_template, net_dev_queue,
>
next prev parent reply other threads:[~2019-11-11 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 14:17 [PATCH] net: add missing semicolon in net_dev_template Tony Lu
2019-11-11 23:12 ` Steven Rostedt [this message]
2019-11-12 7:01 ` Tony Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111181228.49396467@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sanagi.koki@jp.fujitsu.co \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox