* [PATCH net-next] ptp: ptp_clockmatrix: Fix build error
@ 2019-11-12 14:35 YueHaibing
2019-11-12 14:47 ` Vincent Cheng
2019-11-12 20:12 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-11-12 14:35 UTC (permalink / raw)
To: richardcochran, vincent.cheng.xh, davem; +Cc: netdev, linux-kernel, YueHaibing
When do randbuilding, we got this warning:
WARNING: unmet direct dependencies detected for PTP_1588_CLOCK
Depends on [n]: NET [=y] && POSIX_TIMERS [=n]
Selected by [y]:
- PTP_1588_CLOCK_IDTCM [=y]
Make PTP_1588_CLOCK_IDTCM depends on PTP_1588_CLOCK to fix this.
Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/ptp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index c48ad23..b45d2b8 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -121,7 +121,7 @@ config PTP_1588_CLOCK_KVM
config PTP_1588_CLOCK_IDTCM
tristate "IDT CLOCKMATRIX as PTP clock"
- select PTP_1588_CLOCK
+ depends on PTP_1588_CLOCK
default n
help
This driver adds support for using IDT CLOCKMATRIX(TM) as a PTP
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ptp: ptp_clockmatrix: Fix build error
2019-11-12 14:35 [PATCH net-next] ptp: ptp_clockmatrix: Fix build error YueHaibing
@ 2019-11-12 14:47 ` Vincent Cheng
2019-11-12 20:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vincent Cheng @ 2019-11-12 14:47 UTC (permalink / raw)
To: YueHaibing
Cc: richardcochran@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
On Tue, Nov 12, 2019 at 09:35:14AM EST, YueHaibing wrote:
>When do randbuilding, we got this warning:
>
>WARNING: unmet direct dependencies detected for PTP_1588_CLOCK
> Depends on [n]: NET [=y] && POSIX_TIMERS [=n]
> Selected by [y]:
> - PTP_1588_CLOCK_IDTCM [=y]
>
>Make PTP_1588_CLOCK_IDTCM depends on PTP_1588_CLOCK to fix this.
>
>Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
>Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>---
> drivers/ptp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
>index c48ad23..b45d2b8 100644
>--- a/drivers/ptp/Kconfig
>+++ b/drivers/ptp/Kconfig
>@@ -121,7 +121,7 @@ config PTP_1588_CLOCK_KVM
>
> config PTP_1588_CLOCK_IDTCM
> tristate "IDT CLOCKMATRIX as PTP clock"
>- select PTP_1588_CLOCK
>+ depends on PTP_1588_CLOCK
> default n
> help
> This driver adds support for using IDT CLOCKMATRIX(TM) as a PTP
>--
Oops. Thank-you for the fix.
Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ptp: ptp_clockmatrix: Fix build error
2019-11-12 14:35 [PATCH net-next] ptp: ptp_clockmatrix: Fix build error YueHaibing
2019-11-12 14:47 ` Vincent Cheng
@ 2019-11-12 20:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-11-12 20:12 UTC (permalink / raw)
To: yuehaibing; +Cc: richardcochran, vincent.cheng.xh, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 12 Nov 2019 22:35:14 +0800
> When do randbuilding, we got this warning:
>
> WARNING: unmet direct dependencies detected for PTP_1588_CLOCK
> Depends on [n]: NET [=y] && POSIX_TIMERS [=n]
> Selected by [y]:
> - PTP_1588_CLOCK_IDTCM [=y]
>
> Make PTP_1588_CLOCK_IDTCM depends on PTP_1588_CLOCK to fix this.
>
> Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-12 20:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-12 14:35 [PATCH net-next] ptp: ptp_clockmatrix: Fix build error YueHaibing
2019-11-12 14:47 ` Vincent Cheng
2019-11-12 20:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).