From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB38C43331 for ; Wed, 13 Nov 2019 02:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 646D221783 for ; Wed, 13 Nov 2019 02:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573610720; bh=eOU3hIZ/nTfjPK4jdXxifgdMXaDFD9gZboYjupgngJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BOjVw2Q4mpG1vLrH2D2yUXhzwyzBh3RCCghQVWb1KA32nzdb513GEkqiCFIJFWOx8 yMHymY4lEOuxvuiSjgwEAj+QXne6xAOo2GUwZbTwgFkZWc9m3tsedReGt82agRlE8l yvbPLiK7O9bNEeb/1RkZPwZl5XPQxRLaoiTxu27c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730838AbfKMCBo (ORCPT ); Tue, 12 Nov 2019 21:01:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:57812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730825AbfKMCBn (ORCPT ); Tue, 12 Nov 2019 21:01:43 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48F0222470; Wed, 13 Nov 2019 02:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573610503; bh=eOU3hIZ/nTfjPK4jdXxifgdMXaDFD9gZboYjupgngJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d5i8C4/9Khpb85wsqgWwW5PlXL8uDWRQixzv3DMp3+D+vaGkA9HPyK/doQ7hQqDuL u+CHBdBTrr6/S1LhEGoyzAnoKbm10Bgs4XxylmYhEjsRNMu0Mx77y9sm/Vnm6PkTV0 Rm5sC266RnZuWRICEqsBAC2Ny5k+eo9M8sU2i2UE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andrew Zaborowski , Johannes Berg , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 08/48] nl80211: Fix a GET_KEY reply attribute Date: Tue, 12 Nov 2019 21:00:51 -0500 Message-Id: <20191113020131.13356-8-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191113020131.13356-1-sashal@kernel.org> References: <20191113020131.13356-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrew Zaborowski [ Upstream commit efdfce7270de85a8706d1ea051bef3a7486809ff ] Use the NL80211_KEY_IDX attribute inside the NL80211_ATTR_KEY in NL80211_CMD_GET_KEY responses to comply with nl80211_key_policy. This is unlikely to affect existing userspace. Signed-off-by: Andrew Zaborowski Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 4de66dbd5bb60..fd0bf278067ef 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -2879,7 +2879,7 @@ static void get_key_callback(void *c, struct key_params *params) params->cipher))) goto nla_put_failure; - if (nla_put_u8(cookie->msg, NL80211_ATTR_KEY_IDX, cookie->idx)) + if (nla_put_u8(cookie->msg, NL80211_KEY_IDX, cookie->idx)) goto nla_put_failure; nla_nest_end(cookie->msg, key); -- 2.20.1