From: Antoine Tenart <antoine.tenart@bootlin.com>
To: David Miller <davem@davemloft.net>
Cc: antoine.tenart@bootlin.com, linux@armlinux.org.uk,
andrew@lunn.ch, alexandre.belloni@bootlin.com,
nicolas.ferre@microchip.com, netdev@vger.kernel.org,
thomas.petazzoni@bootlin.com, mparab@cadence.com,
piotrs@cadence.com, dkangude@cadence.com, ewanm@cadence.com,
arthurm@cadence.com, stevenh@cadence.com
Subject: Re: [PATCH net-next v2] net: macb: convert to phylink
Date: Wed, 13 Nov 2019 09:16:47 +0100 [thread overview]
Message-ID: <20191113081647.GC4783@kwain> (raw)
In-Reply-To: <20191112.114357.667316757358233747.davem@davemloft.net>
Hi David,
On Tue, Nov 12, 2019 at 11:43:57AM -0800, David Miller wrote:
> From: Antoine Tenart <antoine.tenart@bootlin.com>
> Date: Tue, 12 Nov 2019 15:25:48 +0100
>
> > This patch converts the MACB Ethernet driver to the Phylink framework.
> > The MAC configuration is moved to the Phylink ops and Phylink helpers
> > are now used in the ethtools functions. This helps to access the flow
> > control and pauseparam logic and this will be helpful in the future
> > for boards using this controller with SFP cages.
> >
> > Tested-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
>
> Things like pulling out the buffer init code into a helper function are
> separate from the actual phylink conversion, so please split these changes
> out into separate patches and make this a bonafide patch series.
>
> Please do not forget to provide an appropriate patch series header
> posting when you do this.
Will do for v3.
Thanks,
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-11-13 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 14:25 [PATCH net-next v2] net: macb: convert to phylink Antoine Tenart
2019-11-12 19:43 ` David Miller
2019-11-13 8:16 ` Antoine Tenart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113081647.GC4783@kwain \
--to=antoine.tenart@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=arthurm@cadence.com \
--cc=davem@davemloft.net \
--cc=dkangude@cadence.com \
--cc=ewanm@cadence.com \
--cc=linux@armlinux.org.uk \
--cc=mparab@cadence.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=piotrs@cadence.com \
--cc=stevenh@cadence.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).