From: Andrew Lunn <andrew@lunn.ch>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
ilias.apalodimas@linaro.org, brouer@redhat.com,
lorenzo.bianconi@redhat.com
Subject: Re: [PATCH net-next] net: mvneta: fix build skb for bm capable devices
Date: Thu, 14 Nov 2019 01:06:25 +0100 [thread overview]
Message-ID: <20191114000625.GD27785@lunn.ch> (raw)
In-Reply-To: <2369ff5a16ac160d8130612e4299efe072f53d80.1573686984.git.lorenzo@kernel.org>
On Thu, Nov 14, 2019 at 01:25:55AM +0200, Lorenzo Bianconi wrote:
> Fix build_skb for bm capable devices when they fall-back using swbm path
> (e.g. when bm properties are configured in device tree but
> CONFIG_MVNETA_BM_ENABLE is not set). In this case rx_offset_correction is
> overwritten so we need to use it building skb instead of
> MVNETA_SKB_HEADROOM directly
>
> Fixes: 8dc9a0888f4c ("net: mvneta: rely on build_skb in mvneta_rx_swbm poll routine")
> Fixes: 0db51da7a8e9 ("net: mvneta: add basic XDP support")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reported-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-11-14 0:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 23:25 [PATCH net-next] net: mvneta: fix build skb for bm capable devices Lorenzo Bianconi
2019-11-14 0:06 ` Andrew Lunn [this message]
2019-11-15 2:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114000625.GD27785@lunn.ch \
--to=andrew@lunn.ch \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).