netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	nirranjan@chelsio.com, vishal@chelsio.com, dt@chelsio.com
Subject: Re: [PATCH net-next 1/2] cxgb4: add TC-MATCHALL classifier egress offload
Date: Thu, 14 Nov 2019 18:50:43 +0530	[thread overview]
Message-ID: <20191114132041.GA12021@chelsio.com> (raw)
In-Reply-To: <20191113191402.27dbba26@cakuba>

On Wednesday, November 11/13/19, 2019 at 19:14:02 -0800, Jakub Kicinski wrote:
> On Wed, 13 Nov 2019 20:09:20 +0530, Rahul Lakkireddy wrote:
> > Add TC-MATCHALL classifier offload with TC-POLICE action applied for all
> > outgoing traffic on the underlying interface. Split flow block offload
> > to support both egress and ingress classification.
> > 
> > For example, to rate limit all outgoing traffic to 1 Gbps:
> > 
> > $ tc qdisc add dev enp2s0f4 clsact
> > $ tc filter add dev enp2s0f4 egress matchall skip_sw \
> > 	action police rate 1Gbit burst 8Kbit
> > 
> > Note that skip_sw is important. Otherwise, both stack and hardware
> > will end up doing policing. 
> 
> You also can't offload policers from shared blocks (well, shared
> actions in general, but let's say checking shared blocks is enough).
> 

Ok. Will add a check in v2 to reject police action offload for shared
blocks.

> > Only 1 egress matchall rule can be active
> > at a time on the underlying interface.
> > 
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>

Thanks,
Rahul

  reply	other threads:[~2019-11-14 13:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 14:39 [PATCH net-next 0/2] cxgb4: add TC-MATCHALL classifier offload Rahul Lakkireddy
2019-11-13 14:39 ` [PATCH net-next 1/2] cxgb4: add TC-MATCHALL classifier egress offload Rahul Lakkireddy
2019-11-14  3:14   ` Jakub Kicinski
2019-11-14 13:20     ` Rahul Lakkireddy [this message]
2019-11-13 14:39 ` [PATCH net-next 2/2] cxgb4: add TC-MATCHALL classifier ingress offload Rahul Lakkireddy
2019-11-14  3:16   ` Jakub Kicinski
2019-11-14 13:21     ` Rahul Lakkireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191114132041.GA12021@chelsio.com \
    --to=rahul.lakkireddy@chelsio.com \
    --cc=davem@davemloft.net \
    --cc=dt@chelsio.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    --cc=nirranjan@chelsio.com \
    --cc=vishal@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).